Last modified: 2014-01-18 16:01:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35334, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33334 - Remove database column page.page_restrictions from MediaWiki core
Remove database column page.page_restrictions from MediaWiki core
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
Database (Other open bugs)
1.20.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Tina Johnson ( tinaj1234 )
: easy, schema-change
Depends on:
Blocks: 58674
  Show dependency treegraph
 
Reported: 2011-12-22 19:45 UTC by db [inactive,noenotif]
Modified: 2014-01-18 16:01 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description db [inactive,noenotif] 2011-12-22 19:45:39 UTC
The field of page_restrictions of page table is superseded by the page_restriction table. Please remove that field to keep the database schema clean. Thanks.
Comment 1 db [inactive,noenotif] 2011-12-22 19:57:52 UTC
Yah, the table is called "page_restrictions", the same as the field in page table.
Comment 2 MZMcBride 2013-12-18 22:31:53 UTC
I think it should be fairly easy to remove page.page_restrictions. It just requires a few schema patches, as I recall.
Comment 3 Tina Johnson ( tinaj1234 ) 2014-01-14 12:15:04 UTC
Can I work on this?
Comment 4 Tina Johnson ( tinaj1234 ) 2014-01-16 12:56:12 UTC
I prepared the schema patches but I'm confused as to what is to be done with Title::loadRestrictionsFromRows which compiles page restrictions from both page table and page_restrictions table. There are many occurences of page_restrictions in WikiPage.php. Should all that be removed?
Comment 5 Gerrit Notification Bot 2014-01-18 16:01:27 UTC
Change 108219 had a related patch set uploaded by Tinaj1234:
Removing page_restrictions from page table

https://gerrit.wikimedia.org/r/108219

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links