Last modified: 2012-01-23 19:19:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35376, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33376 - {{#forminput:}} not always creating a form element
{{#forminput:}} not always creating a form element
Status: RESOLVED WORKSFORME
Product: MediaWiki extensions
Classification: Unclassified
SemanticForms (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Yaron Koren
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-25 21:47 UTC by David
Modified: 2012-01-23 19:19 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description David 2011-12-25 21:47:44 UTC
Including {{#forminput:}} in a form definition itself for two different forms results in one input field not being surrounded by <form></form> elements.

In this specific case, the two statements and their respective output are:

{{#forminput:form=Organisation|button text=add it|query string=namespace=Organisation|autocomplete on namespace=Organisation|popup}} }}

resulting in:

<p>
<input id="input_1" class="autocompleteInput createboxInput formInput ui-autocomplete-input" type="text" autocompletesettings="input_1" value="" size="25" name="page_name" autocomplete="off" role="textbox" aria-autocomplete="list" aria-haspopup="true">
<input type="hidden" name="form" value="Organisation">
<input type="hidden" value="Organisation" name="namespace">
<input type="submit" value="add it">
</p>
<p> </p>
<div id="div_1" class="page_name_auto_complete"> </div>
<p></p>

and on the other hand:

{{#forminput:form=Location|button text=add it|autocomplete on category=Location|popup}} }}

resulting in:

<form class="popupforminput" method="get" action="/wiki/Special:FormStart" name="createbox">
<p>
<input id="input_2" class="autocompleteInput createboxInput formInput ui-autocomplete-input" type="text" autocompletesettings="input_2" value="" size="25" name="page_name" autocomplete="off" role="textbox" aria-autocomplete="list" aria-haspopup="true">
<input type="hidden" name="form" value="Location">
<input type="submit" value="add it">
</p>
<p> </p>
<div id="div_2" class="page_name_auto_complete"> </div>
<p></p>
</form>

Since no form elements surround the first (organisation) field, the form this code resides in will be submitted.
Comment 1 Yaron Koren 2012-01-18 16:05:00 UTC
Hi,

I can't reproduce this problem - is this still an issue? If so, what version of Semantic Forms are you using?
Comment 2 Yaron Koren 2012-01-23 19:19:46 UTC
Marking this bug as "worksforme". Feel free to re-open it if you think it's still an issue.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links