Last modified: 2013-10-23 18:17:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35379, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33379 - Set $wgBlockDisablesLogin to true when someone selects the "private wiki configuration"
Set $wgBlockDisablesLogin to true when someone selects the "private wiki conf...
Status: NEW
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.18.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-26 21:14 UTC by Mike Peel
Modified: 2013-10-23 18:17 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mike Peel 2011-12-26 21:14:03 UTC
When a wiki is private (i.e. anon 'read' is disabled), then it would be expected that blocking a user will also remove their read access (i.e. it removes all of the extra rights that their user account has granted to them). However, that is only the case when $wgBlockDisablesLogin is set to true - and by default, it's set to false.

Of course, setting $wgBlockDisablesLogin to true by default would lead to unexpected behaviour in other situations (e.g. on Wikipedia, when logging into a blocked account you wouldn't be able to read any content, so you'd have *less* rights than an anon user has). So a simple 'yes/no' answer doesn't work here.

One possibility would be to make the default $wgBlockDisablesLogin setting conditional on whether anons can read the wiki - if they can, then it's false, if they can't, then true. That could then be overwritten by specifying a setting in LocalSettings.php.

Another one would be to add an option when blocking a user to also remove their read access (either by Special:Block and/or Special:UserRights).

(As a secondary issue: I note that while the default text at Special:Block does indicate that it blocks editing, it doesn't specify that it only blocks editing and not reading, and nor does that text change if $wgBlockDisablesLogin is set to true...)
Comment 1 Bawolff (Brian Wolff) 2011-12-26 23:58:56 UTC
>One possibility would be to make the default $wgBlockDisablesLogin setting
>conditional on whether anons can read the wiki - if they can, then it's false,
>if they can't, then true. That could then be overwritten by specifying a
>setting in LocalSettings.php.

That could certainly be done. Another possibility is to just have the installer set $wgBlockDisablesLogin to true when someone selects the "private wiki configuration" (Won't affect existing wikis or custom set up wikis, but would make new ones be more like what the user probably wants)
Comment 2 p858snake 2011-12-27 00:03:44 UTC
(In reply to comment #0)
> Of course, setting $wgBlockDisablesLogin to true by default would lead to
> unexpected behaviour in other situations (e.g. on Wikipedia, when logging into
> a blocked account you wouldn't be able to read any content, so you'd have
> *less* rights than an anon user has). So a simple 'yes/no' answer doesn't work
> here.
We would just over-ride it, like we do with many other settings. We already have that enabled on the private wiki group by default.


I have always seen blocking as a method to stop people editing for a variety of different reasons (spam being one) and we shouldn't mix up what blocking means by having different meanings and actions on a "public" vs "private" setup, unless the end consumer wants to setup that way.
Comment 3 Chad H. 2011-12-27 17:53:13 UTC
(In reply to comment #2)
> I have always seen blocking as a method to stop people editing for a variety of
> different reasons (spam being one) and we shouldn't mix up what blocking means
> by having different meanings and actions on a "public" vs "private" setup,
> unless the end consumer wants to setup that way.

If we made blocking a per-right affair (bug 14636) and made logging in a user right, it would make the separation much clearer.
Comment 4 Nemo 2012-11-24 10:28:36 UTC
$wgBlockDisablesLogin works well enough IMHO.

(In reply to comment #1)
> Another possibility is to just have the installer
> set $wgBlockDisablesLogin to true when someone selects the "private wiki
> configuration" (Won't affect existing wikis or custom set up wikis, but would
> make new ones be more like what the user probably wants)

Makes sense: moving to installer and changing summary.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links