Last modified: 2012-07-30 08:56:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35385, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 33385 - Translatable pages and FlaggedRevs don't play nice together


Summary:	Translatable pages and FlaggedRevs don't play nice together

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Translate (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal major (vote)
Target Milestone:	---
Assigned To:	Niklas Laxström

URL:	http://translatewiki.net/wiki/Thread:...
Whiteboard:
Keywords:	i18n

Duplicates:	35135 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-12-27 15:42 UTC by Siebrand Mazeland
Modified:	2012-07-30 08:56 UTC (History)
CC List:	8 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Siebrand Mazeland 2011-12-27 15:42:29 UTC

Putting this under FlaggedRevs, but it's really an extension interaction issues that probably requires some discussion on how to resolve it.

Translatable pages (using the Translate extension) cannot be edited, because they are aggregated from text parts that are put into a template. preventDirectEditing() in extensions/Translate/tag/PageTranslationHooks.php. Because I cannot edit the page (no one can actually), FlaggedRevs refuses to allow me to approve any revisions.

I think the expected behaviour here would be for FlaggedRevs to allow me to approve stable versions.

Something's gotta give, but what/how? :)

Comment 1 Aaron Schulz 2012-01-05 00:54:36 UTC

I'm not too familiar with the workflow. How are these revisions being created https://www.mediawiki.org/w/index.php?title=Help:Extension:WebFonts/nl&action=history ?

Comment 2 Niklas Laxström 2012-01-05 07:41:07 UTC

Translators translate the individual pieces in Translations: namespace, see https://www.mediawiki.org/wiki/Special:Contributions/GerardM

Then the extension is hooked to SaveComplete hook, rebuilding the full translation page, copying all the edit options (except EDIT_NEW, EDIT_UPDATE) from the original edit.

Comment 3 Aaron Schulz 2012-03-08 19:43:07 UTC

Fixed in r113389.

Comment 4 Aaron Schulz 2012-03-10 22:30:24 UTC

*** Bug 35135 has been marked as a duplicate of this bug. ***

Comment 5 Niklas Laxström 2012-04-28 13:15:20 UTC

https://gerrit.wikimedia.org/r/#change,3453

Comment 6 Niklas Laxström 2012-07-19 07:53:20 UTC

It was reported that still gives "Permission denied" and I can confirm that. Please advice whether this can be fixed in FlaggedRevs or in Translate extension.

Comment 7 Aaron Schulz 2012-07-20 02:33:39 UTC

The preventDirectEditing() hook is blocking all actions other than a few. I can do anything in FlaggedRevs. I tested this in eval.php.

Comment 8 Niklas Laxström 2012-07-20 18:47:31 UTC

Assuming you mean "can't". Do you suggest using whitelist or blacklist for actions?

Comment 9 Aaron Schulz 2012-07-21 17:35:51 UTC

(In reply to comment #8)
> Assuming you mean "can't". Do you suggest using whitelist or blacklist for
> actions?

Yeah I meant "can't".

Right now you have a tiny whitelist. You could just add 'review' to it. In the long term it seems like a blacklist might make more sense. It seems like the function really just wants to prevent editing and moves.

Comment 10 Niklas Laxström 2012-07-23 10:19:21 UTC

https://gerrit.wikimedia.org/r/16280

Comment 11 Niklas Laxström 2012-07-30 08:56:53 UTC

Patch has been merged. Please test once it has been deployed (probably 8.8.) and mark as verified.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links