Last modified: 2013-05-04 11:57:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35494, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 33494 - Remove redundant CSS from chick/main.css
Remove redundant CSS from chick/main.css
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.20.x
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-01-03 21:45 UTC by Erwin Dokter
Modified: 2013-05-04 11:57 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Patch for /skins/chick/main.css (2.26 KB, patch)
2012-01-03 21:45 UTC, Erwin Dokter 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Erwin Dokter 2012-01-03 21:45:57 UTC 
Created attachment 9795 [details]
Patch for /skins/chick/main.css

This patch removes any redundant CSS from skins/chick/main.css that has moved to skins/common/commonElement.css. I guess this was an oversight; it was removed from all other skin files, but not this one.
Comment 1 Sam Reed (reedy) 2012-01-04 17:30:26 UTC 
r108055, thanks!
Comment 3 Krinkle 2012-01-22 01:46:25 UTC 
Chick would first have to be switched to actually use commonElements (and perhaps the other common ones as well).

Doing so requires good visual  testing, since it could contain styles that change defaults. So before/after needs is important.
Comment 4 Erwin Dokter 2012-01-22 02:48:30 UTC 
I asumed it was for all skins, but having looked in Resource.php I see they are for Monobook and Vector only. This is a bit odd since we end up with duplicate CSS. I checked the flies line-by-line and there were no differences in the duplications. Begs the question why the CSS was split up in the first place? Skin-specific CSS should be placed in their respective skin files.
Comment 5 Erwin Dokter 2013-05-04 11:57:07 UTC 
With Chick obsolete, so is this bug.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links