Last modified: 2012-01-04 21:30:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35525, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 33525 - clearTagHooks doesn't clear function hooks
clearTagHooks doesn't clear function hooks
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.20.x
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-01-04 21:21 UTC by Nikola Kovacs
Modified: 2012-01-04 21:30 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
patch (379 bytes, patch)
2012-01-04 21:21 UTC, Nikola Kovacs 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Nikola Kovacs 2012-01-04 21:21:04 UTC 
Created attachment 9805 [details]
patch

Parser:clearTagHooks clears mTagHooks and resets mStripList to the default. However, it does not clear mFunctionTagHooks.

setFunctionTagHook adds a function tag to the strip list, so this creates an inconsistent state, where the tag is present in mFunctionTagHooks, but not mStripList.

As far as I can tell, clearTagHooks isn't called anywhere in core, and I don't know what its purpose is, but just clearing function tag hooks as well in clearTagHooks seems like a sensible fix.
Comment 1 Sam Reed (reedy) 2012-01-04 21:30:38 UTC 
Applied in r108087, thanks!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links