Last modified: 2012-02-24 02:52:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35529, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33529 - Switch from iframe to div using iscroll4 (experimental)
Switch from iframe to div using iscroll4 (experimental)
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Generic (Other open bugs)
1.0.0 (Android)
All All
: Normal normal
: ---
Assigned To: Brion Vibber
http://cubiq.org/iscroll-4
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-05 01:16 UTC by Brion Vibber
Modified: 2012-02-24 02:52 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: Android
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2012-01-05 01:16:35 UTC
Given all the troubles we have with the iframe:
* can't size the iframe as we wish on android 2.x
* clicking event distribution problems when scrolling under position:fixed elements
* different clicking event distribution problems when scrolling an iframe itself on honeycomb and ics
* etc

it's worth trying to put the content in a <div> instead, which will allow us to take over the scrolling behavior with a library like iscroll:

http://cubiq.org/iscroll-4

(Can't do that with an iframe as the events don't traverse the frame boundary, very messy!)
Comment 1 Brion Vibber 2012-01-06 00:32:05 UTC
We've moved to divs in the current master; I have an older branch initially testing some stuff with iscroll:

https://github.com/brion/Wikipedia/tree/refactor-iframe

It seems to work nicely, including pinch-to-zoom on Android 4 and double-tap-to-zoom on Android 2.3... however it's much too slow on my Nexus 1, especially on longer articles, and will just be slower on less powerful devices.

We may wish to try this again once we've done things like only loading sections that are being viewed, so there's less processing to do.
Comment 2 Brion Vibber 2012-01-27 22:17:14 UTC
Switched to divs a while ago, since the SF hackathon (January 21-ish) now with iscroll4 in use for iOS 4.x, and full-screen scrolling fallback for Android 2.x.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links