Wikimedia Bugzilla is closed!

Created attachment 10227 [details]
Proposed patch for hiding "Print with PediaPress"

While I think that the best solution would be a configuration variable, I have attached a patch which works around this issue hiding the box "Print with PediaPress" (i.e. make it not appear in Special:Book).

+patch+need-review

Mini-review: We should really do this properly with a configuration variable compared to a css hiding due to the concerns linked to c0.

my children need something to eat! we can't turn that off.

seriously, I'd like a way to configure the mPODPartners and turn the functionality off, if mPODPartners is empty. 

side note: please provide patches in unified diff format.

Working on it. The code isn't really  ready for multiple $this->mPODPartners. Do you mind if I commit my change to SVN trunk for review when done?

Isn't that a bit late for *review*?

Bit I'm no code review nazi, so feel free to go ahead.

Fixed in r113740.

Now you can do:

$wgCollectionPODPartners["mojapress"] = array(
        'name' => 'MojaPress',
        'url' => 'http://mojapress.com/',
        'posturl' => 'http://mojapress.com/api/collections/',
);
$wgCollectionPODPartners["trzeciapress"] = array(
        'name' => 'TrzeciaPress',
        'url' => 'http://trzeciapress.com/',
        'posturl' => 'http://trzeciapress.com/api/collections/',
        'infopagetitle' => 'coll-trzeciapress_article'
);

or, if you really don't want it:

$wgCollectionPODPartners = false;

in your LocalSettings.php

Thanks Marcin.