Last modified: 2014-05-06 15:26:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35562, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33562 - Update jquery.tipsy plugin to latest version
Update jquery.tipsy plugin to latest version
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.20.x
All All
: Normal enhancement (vote)
: Future release
Assigned To: Nobody - You can work on this!
https://github.com/jaz303/tipsy/
:
Depends on: 35241
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-06 16:05 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-05-06 15:26 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2012-01-06 16:05:04 UTC
jquery.tipsy https://github.com/jaz303/tipsy/ received some updates upstream although there is no new release yet.

I have asked the author to tag a new version. We could then rebase our local change on top of it and update our local copy :)

I already cherry picked a feature see bug 29309 / r108244
Comment 1 Krinkle 2012-01-13 23:57:14 UTC
-upstream, this is not a bug to be fixed upstream.
Comment 2 Antoine "hashar" Musso (WMF) 2012-03-04 08:48:13 UTC
I guess upstream author abandoned or lost interest into the project. Despite 29 pull requests and several mails sent to his various email addresses, I have not heard back from him.

I think we should take over the project and fork it under the wikimedia team on Github. Merge the pull requests, include our changes. Then release a new version making it clear we are taking over the project.
Comment 3 Antoine "hashar" Musso (WMF) 2012-03-15 07:23:48 UTC
See bug 35241 - take over jquery.tipsy plugin
Comment 4 kipod 2012-03-16 19:13:03 UTC
also please note that tipsy upstream  head version has a bug in the "getTitle()" function
(same bug exists in the version currently used by mediawiki):
        
        getTitle: function() {
            var title, $e = this.$element, o = this.options;
            fixTitle($e);
            var title, o = this.options;
            if (typeof o.title == 'string') {
                title = $e.attr(o.title == 'title' ? 'original-title' : o.title);

the last line should clearly be

                title = o.title == 'title' ? $e.attr('original-title') : o.title;

this bug basically means you can't use a string in tipsy title - only functions work.

in addition, the 4th line 
("
            var title, o = this.options;
") 
is clearly junk and should just be removed - it redeclares two variables that are already declared.

peace.
Comment 5 Antoine "hashar" Musso (WMF) 2014-05-06 15:26:56 UTC
There is no real interest in following upstream and we made our own hack essentially producing a fork.  I am closing this bug since updating will only causes issues and does not add anything to the plate.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links