Last modified: 2012-02-08 02:34:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35575, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33575 - [SMW] Semantic Search offset incorrect on first display after clicking "further results" in table
[SMW] Semantic Search offset incorrect on first display after clicking "furth...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Semantic MediaWiki (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-07 02:18 UTC by badon
Modified: 2012-02-08 02:34 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description badon 2012-01-07 02:18:09 UTC
When clicking "further results" for the first time, the "next" link for results 1-20 on the Semantic Search page is loaded with an offset of 0, which basically just reloads results 1-20 again (login with Demo/test):

http://www.coincompendium.com/w/index.php/Special:Ask/-5B-5BCategory:CCT666-5D-5D-20-5B-5BCategory:Specimens-5D-5D/-3F-23/-3FGrade/-3FModification-20date/mainlabel%3D/order%3DDESC/sort%3D_MDAT

If you click "next" a second time after it reloads, then it finally shows results 21-40, using the correct offset value of 20:

http://www.coincompendium.com/w/index.php?title=Special:Ask&offset=20&limit=20&q=%5B%5BCategory%3ACCT666%5D%5D+%5B%5BCategory%3ASpecimens%5D%5D&p=mainlabel%3D%2Fformat%3Dbroadtable&po=%3F%23-%0A%3FGrade%0A%3FModification+date%0A&sort=_MDAT&order=DESC
Comment 1 Jeroen De Dauw 2012-01-07 04:08:54 UTC
Should be fixed by r108306. Can you confirm it now works correctly in all cases?
Comment 2 badon 2012-01-08 20:32:52 UTC
I couldn't find any difference, the offset is still 0. I overwrote my SMW_QueryResult.php with this file, which I think is the correct way to test this since the only other changed file seems to be README, if I understand correctly:

https://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/SemanticMediaWiki/includes/storage/SMW_QueryResult.php?revision=108306&view=co&pathrev=108306

I reopened this bug, but if there's something else I need to do to properly test this, let me know.
Comment 3 badon 2012-02-08 02:34:01 UTC
I tested this issue in SMW 1.7.0.2, and it appears to be fixed. I presume that is r109014.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links