Last modified: 2012-02-24 02:52:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35615, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33615 - Intermittent off-by-one in "Read in..." language selection on ICS (Android 4.0)
Intermittent off-by-one in "Read in..." language selection on ICS (Android 4.0)
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Generic (Other open bugs)
1.0.0 (Android)
All All
: Normal normal
: ---
Assigned To: Brion Vibber
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-09 21:25 UTC by Brion Vibber
Modified: 2012-02-24 02:52 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: Android
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2012-01-09 21:25:04 UTC
Seems to happen fairly often on my Galaxy Nexus (Android 4.0.2), but can't reproduce on a Nexus One (Android 2.3.6).

When selecting a language from the "Read in..." menu, about half the time it's coming back with the next language in the list -- for instance selecting Turkish and getting Vietnamese.

May be a freak weird thing, or something odd about the events and scrolling or something.
Comment 1 Brion Vibber 2012-01-09 21:48:39 UTC
Not scrolling related that I can see; happens when nothing is being scrolled.

Seems to just be sending 'click' events to the next <a> in the list when you tap near the bottom of one of the links...

Touchstart/touchend events, and the :hover pseudoclass that's used to highlight, don't seem to see this special case, so it's showing highlighting for the one above but clicking the one below. Nasty!


https://github.com/brion/Wikipedia/commits/touch-work
^ attempts to use touchstart/touchend events instead of click to avoid the bug. Works, but breaks scrolling on Android 2.3.x.
Comment 2 Brion Vibber 2012-01-09 21:52:09 UTC
This also happens in the 'saved pages' and 'history' lists.
Comment 3 Phil Chang 2012-01-24 18:41:33 UTC
Is this dependent on fixes in ICS?
Comment 4 Yuvi Panda 2012-02-15 18:06:24 UTC
'Fixed' in ac85f57ceae4c20112207d2655 by getting rid of the touch highlights. Thanks to Gaurav for the patch!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links