Last modified: 2012-01-11 17:40:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35620, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33620 - SwiftMedia's rewrite prohibits images and thumbnails with the string AUTH in the filename
SwiftMedia's rewrite prohibits images and thumbnails with the string AUTH in ...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Other (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-09 23:11 UTC by Ben Hartshorne
Modified: 2012-01-11 17:40 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ben Hartshorne 2012-01-09 23:11:09 UTC
Part of the rewrite logic in SwiftMedia's wmf/rewrite.py says:
  # if it already has AUTH, presume that it's good. #07
  if req.path.startswith('/auth') or req.path.find('AUTH') >= 0:
     return self.app(env, start_response)

This logic is invalid because image names are allowed to have the four characters AUTH as part of the filename.  For example, http://upload.wikimedia.org/wikipedia/commons/thumb/8/87/Bhartshorne-test-AUTH-image.jpg/240px-Bhartshorne-test-AUTH-image.jpg is an acceptable filename and works with the old system but not via swift.  

SwiftMedia should only skip rewriting if something like AUTH_0123456789abcdef0123456789abcdef is present, not just AUTH.
Comment 1 Ben Hartshorne 2012-01-11 00:14:46 UTC
fixed in https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108569

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links