Last modified: 2012-01-31 09:31:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35646, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 33646 - "Bad title" error page returns HTTP 200 OK instead of an error code


Summary:	"Bad title" error page returns HTTP 200 OK instead of an error code

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	General/Unknown (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:	http://en.wikipedia.org/wiki/%23
Whiteboard:
Keywords:	easy, platformeng

Depends on:
Blocks:	33628
	Show dependency tree / graph

Reported:	2012-01-10 21:08 UTC by Brion Vibber
Modified:	2012-01-31 09:31 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Brion Vibber 2012-01-10 21:08:47 UTC

"Bad title" page is served with an HTTP 200 "OK" response, should be 400 or maybe 403 or 404.

Blocks bug 33628 -- mobile client is unable to determine that this was an error case because the page comes back without an HTTP-level error indication.

Comment 1 Antoine "hashar" Musso (WMF) 2012-01-12 23:07:42 UTC

We could create a BadTitleError exception which would just call ErrorPageError( 'bad title', 'badtitletext' ) and set the 400 error code.

Comment 2 Sumana Harihareswara 2012-01-12 23:23:37 UTC

Marked "easy" because hashar placed this on the http://www.mediawiki.org/wiki/Annoying_Little_Bug page.

Comment 3 Phil Chang 2012-01-24 22:43:04 UTC

Brion, who is the right person for this? And should we make any dependency on this in forthcoming mobile releases?

Comment 4 Antoine "hashar" Musso (WMF) 2012-01-25 07:17:57 UTC

Phil > I guess that kind of bug is for Platform Engineering (I am a member of that team).

I did not notice it was blocking for Mobile applications.

Tagging +platformeng.

Comment 5 Antoine "hashar" Musso (WMF) 2012-01-25 10:52:04 UTC

Added a new exception class with r110001.

Comment 6 Phil Chang 2012-01-26 17:51:57 UTC

Great, thanks! When might this change actually appear in production?

Comment 7 Antoine "hashar" Musso (WMF) 2012-01-31 09:31:17 UTC

(In reply to comment #6)
> Great, thanks! When might this change actually appear in production?

The process is to have the change pair reviewed. Then it is applied to the production branch and then deployed by someone with shell access.

The change was merged by Roan Kattouw a few minutes ago with r110368 and applied on live site:

$ curl -I 'http://en.wikipedia.org/wiki/%5B%5B'
HTTP/1.0 400 Bad Request
<snip>

So that is live :-)

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links