Last modified: 2012-02-24 02:52:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35656, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33656 - The search box should lose focus when a Go action is performed.
The search box should lose focus when a Go action is performed.
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Generic (Other open bugs)
1.0.0 (Android)
All All
: Normal normal
: ---
Assigned To: Yuvi Panda
:
Depends on:
Blocks: 31805
  Show dependency treegraph
 
Reported: 2012-01-11 11:34 UTC by Liangent
Modified: 2012-02-24 02:52 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: Android
Assignee Huggle Beta Tester: ---


Attachments

Description Liangent 2012-01-11 11:34:12 UTC
The "Go" button is the one on the on-screen keyboard. (TouchPal)
Comment 1 Phil Chang 2012-01-25 00:03:27 UTC
Noticing a similar problem with hardware search key highlighting the search field.
Comment 2 Andrea Stagi 2012-01-26 01:28:28 UTC
Fixed with my new pull request! https://github.com/wikimedia/WikipediaMobile/pull/122
Comment 3 Brion Vibber 2012-01-26 18:20:33 UTC
I'm not quite sure I understand this bug; in my testing on Nexus 1, focus seems to do what I expect offhand when hitting the 'go' button.

commit 3f6c44ba07b0fcaa014926a57f8ae7bdda65f865 in Andrea's branch appears to explicitly disable the search box during navigation, which worries me -- I think we'd want that to still work so if the load takes a long time you can start doing something else.
Comment 4 Andrea Stagi 2012-01-26 18:29:37 UTC
I understand it in this way: please disable search box during navigation.. Anyway Brion I'm agree with you, anyway user could cancel the action of loading.. would you like I make a reverse commit? refactoring is to be considered anyway, I will remove only the part of disabling search box..
Comment 5 Liangent 2012-01-27 14:37:24 UTC
(In reply to comment #4)
> I understand it in this way: please disable search box during navigation..
> Anyway Brion I'm agree with you, anyway user could cancel the action of
> loading.. would you like I make a reverse commit? refactoring is to be
> considered anyway, I will remove only the part of disabling search box..

See [[Focus (computing)]].
Comment 6 Andrea Stagi 2012-01-30 03:02:45 UTC
Thanks for the reference ^^ thanks for reporting this bug, was not a graphical only question! this bug is fixed, someone merge this plz: https://github.com/wikimedia/WikipediaMobile/pull/128 .
Comment 7 Phil Chang 2012-01-30 04:00:52 UTC
Hopefully this also fixed the bug about search box not losing focus after search with hardware search key.
Comment 8 Andrea Stagi 2012-01-30 13:25:20 UTC
Uhm no sorry, they are not related.. anyway for that I opened another pull request, so will be fixed soon ^^

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links