Last modified: 2012-05-17 05:48:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35658, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33658 - Add support for {{GRAMMAR:}} to the mediawiki.jqueryMsg module
Add support for {{GRAMMAR:}} to the mediawiki.jqueryMsg module
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.18.x
All All
: Normal normal (vote)
: ---
Assigned To: Krinkle
: i18n, javascript, patch
Depends on: 33653
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-11 12:04 UTC by Santhosh Thottingal
Modified: 2012-05-17 05:48 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Add support for grammar in js message parsing (9.78 KB, patch)
2012-01-11 12:04 UTC, Santhosh Thottingal
Details

Description Santhosh Thottingal 2012-01-11 12:04:10 UTC
Created attachment 9841 [details]
Add support for grammar in js message parsing

jqueryMsg parser does not support GRAMMAR and language specific grammar rules are not available at javascript.

Atached patch tries to resolve this:

1. make jqueryMsg understand GRAMMAR. Depend on the patch at Bug 33653
2. Make SITENAME with value mw.config.get( 'wgSiteName' ) available in parser without the need of module users explicitly adding it.
3. mw.language get convertGrammar, can be overridden per language as in php
4. Make global variable wgGrammarForms available at js by adding to ResourceLoader default variables.
5. Language.php get a method to filter wgGrammerForms for the current contentLanguage.
6. Qunit tests

Not committing the code now, because core code is in 'slush'
Comment 1 Siebrand Mazeland 2012-01-11 18:46:37 UTC
Extra keyword won't hurt :).
Comment 2 Niklas Laxström 2012-01-16 16:55:59 UTC
Typo: noders. New methods should have @since tag. Patch is reviewed.
Comment 3 Siebrand Mazeland 2012-02-16 08:43:58 UTC
In r111627 I created a branch for this. We can put the basic implementation in there, and it will also contain a JavaScript implementation of the existing grammar classes and QUnit tests for them.

Once we've worked everything out, have it coded and reviewed, we can merge the branch into trunk.
Comment 4 Santhosh Thottingal 2012-05-17 05:48:34 UTC
See https://gerrit.wikimedia.org/r/4078. closing.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links