Last modified: 2014-11-17 10:34:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35671, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33671 - Edit section links do not display while using diff=curr
Edit section links do not display while using diff=curr
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Low normal with 6 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-11 21:57 UTC by Jelle Zijlstra
Modified: 2014-11-17 10:34 UTC (History)
13 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jelle Zijlstra 2012-01-11 21:57:42 UTC
In pages like http://en.wikipedia.org/w/index.php?title=User_talk:Redrose64&diff=curr , no editsection links are shown, even though the page displayed is (by definition) the current version. Curiously, there are editsection links on http://en.wikipedia.org/w/index.php?title=User%20talk:Ucucha&diff=curr .

These links used to appear until earlier today. The bug is presumably caused by r108622, which merged r100756 and r92703 into 1.18wmf1. Not sure which of those is the culprit.
Comment 2 kipod 2012-01-16 15:09:46 UTC
for some very curious reason, this seem to be broweser-dependent: the same URL shows the editsection links with chrome and IE8, but they disapear with FF and IE9.
Comment 3 Sandrobt 2012-01-24 19:30:10 UTC
The same in it.wiki, this problem is pretty annoying, since it happens quite often to have a look to the last change of a page and see there is some corrections needed.
Comment 4 Amalthea 2012-01-25 17:06:06 UTC
The edit links seem to be displayed correctly if a Special page is transcluded onto the page, like Ucucha does. Which is odd.

See two test pages, the second transcludes a special page and shows the section edit links:
https://en.wikipedia.org/wiki/User:Amalthea/test19?diff=cur
https://en.wikipedia.org/wiki/User:Amalthea/test20?diff=cur

Adding demon since I *guess* that this is caused by r92703, hopefully he can say.
Comment 5 TMg 2012-01-29 21:25:03 UTC
Anybody working on this? I never get the edit-section links when I visit the pages on my watchlist. It should not be to hard to track this down since it *always* happens, at least in the German Wikipedia. Steps to reproduce:

* Click "Random page".
* Click "View history".
* Click "prev" to see the diff for the last edit.

No edit-section links.
Comment 6 MrBlueSky 2012-01-29 22:45:02 UTC
Looks like its fixed in 1.19. On http://labs.wikimedia.beta.wmflabs.org/wiki/Main_Page i get edit-sections on latest diffs.
Comment 7 Brad Jorsch 2012-02-06 17:46:34 UTC
(In reply to comment #6)
> Looks like its fixed in 1.19. On
> http://labs.wikimedia.beta.wmflabs.org/wiki/Main_Page i get edit-sections on
> latest diffs.

Looks like it was (accidentally?) fixed in r103001 and r103002. Those revisions made the diff code create its own ParserOptions from its own context, instead of getting the ParserOptions from OutputPage which (since r92703) will always hide the section edit links.
Comment 8 Aaron Schulz 2012-03-14 00:41:11 UTC
I can't reproduce this on enwiki.
Comment 9 matanya 2012-03-14 00:44:05 UTC
fixed in 1.19 so you can't reproduce anymore.
Comment 10 Brad Jorsch 2012-06-09 15:45:41 UTC
Since this is widely reported as fixed in 1.19, let's mark it that way.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links