Last modified: 2012-01-16 13:15:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35702, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 33702 - SF svn rev 108803 - adding multiple instance templates broken


Summary:	SF svn rev 108803 - adding multiple instance templates broken

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	SemanticForms (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal major (vote)
Target Milestone:	---
Assigned To:	Yaron Koren

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-01-13 10:49 UTC by Neill Mitchell
Modified:	2012-01-16 13:15 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Neill Mitchell 2012-01-13 10:49:06 UTC

Hi.

I have just tried SF revision 108803 and multiple instance templates seem to be broken. When I click on the "Add another" button, nothing happens. When I revert to SF version 2.3.2 it all works again.

I'm running MW 1.16.5 and SMW 1.5.6.

Thanks.
Neill.

Comment 1 Niklas Laxström 2012-01-15 10:07:50 UTC

For me this is because SemanticForms.js has custom code, probably copy-pasted from http://www.learningjquery.com/2010/06/a-jquery-ui-combobox-under-the-hood and ignoring the remarks of not using *jquery.ui* namespace for custom widgets. 

Anyway .combobox() is called before the code that defines it is run.

For you it is probably because MW 1.16 does not have a resource loader. 1.16 is not receiving security updates and you should plan for upgrade. I would recommend keeping the version of MW and SMW mostly in the same level with regards to release time.

Comment 2 Yaron Koren 2012-01-16 03:45:44 UTC

This was indeed due to the use of MW 1.16. SF still supports it, although it's true that anyone using it should upgrade already. Anyway, I think I just fixed this in SVN. (I also reduced the priority to "Normal". :) )

Comment 3 Niklas Laxström 2012-01-16 07:24:27 UTC

Since you totally ignored my problem, I made it a bug 33747.

Comment 4 Neill Mitchell 2012-01-16 09:04:12 UTC

I'll check out the fix.

Thanks.
Neill.

Comment 5 Yaron Koren 2012-01-16 13:15:54 UTC

Niklas - well, you did the right thing; two unrelated problems should get two different bug reports.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links