Last modified: 2012-01-14 17:29:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35713, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33713 - Show "previous" revisions in addition to follow-ups
Show "previous" revisions in addition to follow-ups
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-13 22:57 UTC by Krinkle
Modified: 2012-01-14 17:29 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2012-01-13 22:57:18 UTC
Right now associating revisions only goes one way. That's fine in the backend, but in the front-end it'd be nice if it reverse could be shown as well.

For example r108869 follows-up r108866. On r108866 it is listed under Follow-up revisions, but there is no link the other way.

Of course when the revision id is mentioned in the commit message it can be linked from there, but in particularly long commit messages it'd still be convenient to have them listed and in ascending order.

Perhaps rename "Follow-up revisions" section to "References revisions" and show a table for each direction ? (or add another section).

Possible issue: Database query may not be indexed the other way around.
Comment 1 Sam Reed (reedy) 2012-01-14 15:17:50 UTC
We already have "CodeReivision::addReferencesFrom()" and "CodeReivision::addReferencesTo()"

As for indexes, we are fine:

-- And for our commenting system...
-- To specify follow-up relationships...
CREATE TABLE /*_*/code_relations (
  cf_repo_id int not null,
  -- -> cr_id
  cf_from int not null,
  -- -> cr_id
  cf_to int not null,

  primary key (cf_repo_id, cf_from, cf_to)
) /*$wgDBTableOptions*/;

CREATE INDEX /*i*/repo_to_from ON /*_*/code_relations (cf_repo_id, cf_to, cf_from);



Always filter by the repo, then we can do a query on to or from no issue!
Comment 2 Sam Reed (reedy) 2012-01-14 16:00:32 UTC
r108907, r108911, r108912
Comment 3 Sam Reed (reedy) 2012-01-14 16:19:29 UTC
Are you wanting the ability to add newer revisions which follow it up? I guess it'd be useful for adding revisions in from comments etc...
Comment 4 Sam Reed (reedy) 2012-01-14 17:29:15 UTC
Done. The only thing that might need message tweaks

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links