Last modified: 2012-04-16 09:15:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35729, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 33729 - JavaScript breaks when a page is in a hidden category


Summary:	JavaScript breaks when a page is in a hidden category

Status:	VERIFIED WORKSFORME

Product:	MediaWiki
Classification:	Unclassified
Component:	JavaScript (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-01-14 21:16 UTC by Filip Maljkovic [Dungodung]
Modified:	2012-04-16 09:15 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Filip Maljkovic [Dungodung] 2012-01-14 21:16:55 UTC

There seems to be a problem with JS when an article is in a hidden category. It breaks with the following error message (as seen in Chrome's console):
Uncaught ReferenceError: isClass is not defined
 hiddencat
 window.runOnloadHook

I get that on srwiki, so current Wikimedia deployment branch of MediaWiki.

Example URL: http://sr.wikipedia.org/w/index.php?title=En_nombre_del_Amor&diff=next&oldid=5160786

Comment 1 Lupo 2012-01-16 08:19:39 UTC

This is a bug in [[sr:MediaWiki:Common.js]], line 140: function isClass is not defined.

Not a MediaWiki bug, but a bug in the local site-wide JS.

To fix, replace all occurrenes of "isClass" in [[sr:MediaWiki:Common.js]] by "hasClass" (defined on line 38 of the same file).

Comment 2 Antoine "hashar" Musso (WMF) 2012-01-16 09:51:43 UTC

Thanks Lupo for investigating this issue :)

Comment 3 Filip Maljkovic [Dungodung] 2012-01-16 09:57:33 UTC

OK, I've fixed the JS page and can confirm that it works now.

Thanks

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links