Last modified: 2013-07-16 16:12:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35730, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33730 - file revert links on ImagePage not shown for anons
file revert links on ImagePage not shown for anons
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
1.20.x
All All
: Low normal (vote)
: ---
Assigned To: Alexandre Emsenhuber [IAlex]
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-14 21:59 UTC by db [inactive,noenotif]
Modified: 2013-07-16 16:12 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description db [inactive,noenotif] 2012-01-14 21:59:28 UTC
The file revert links on a image page has a loggedIn check. I am not sure, why this is needed? The only problem is, when click the link there is no form to change the comment and confirm the revert, the revert is done directly with the link. That is possible, because the edit token is given in the link. But for loggedin users the form used another edit token and the edit token from the link is not needed.

By the way: The permission check for that link should check against 'upload', not 'edit'.

LocalSettings:
$wgGroupPermissions['*']['upload']     = true;
Comment 1 Jesús Martínez Novo (Ciencia Al Poder) 2013-07-15 18:24:05 UTC
On current master, with $wgGroupPermissions['*']['upload'] = true; I'm able to revert a file like any other normal user, using the same workflow.

The problem you described "when click the link there is no form to
change the comment and confirm the revert" does not happen to me. Can you please confirm whether is this bug still valid?
Comment 2 db [inactive,noenotif] 2013-07-16 16:12:11 UTC
was fixed with Gerrit change #9264

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links