Last modified: 2012-02-10 20:39:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35867, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33867 - Preview Semantic Forms
Preview Semantic Forms
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SemanticForms (Other open bugs)
unspecified
All All
: Unprioritized enhancement (vote)
: ---
Assigned To: Yaron Koren
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-21 22:54 UTC by Solitarius
Modified: 2012-02-10 20:39 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch to allow preview of forms (3.67 KB, patch)
2012-01-21 22:55 UTC, Solitarius
Details

Description Solitarius 2012-01-21 22:54:03 UTC
It's currently not possible to preview a Form when you're editing it. Even if you remove the <includeonly> tag of a Form the form template won't be understood by the parser.
Comment 1 Solitarius 2012-01-21 22:55:23 UTC
Created attachment 9883 [details]
Patch to allow preview of forms
Comment 2 Solitarius 2012-01-21 22:56:24 UTC
Arguments to formHTML
Comment 3 Solitarius 2012-01-21 22:58:50 UTC
Also the message sf_preview_note need to be translated to English.
Comment 4 Solitarius 2012-01-21 23:02:05 UTC
While previewing, certain items such as wpSave or wpSummary are in double (once of the Form Preview and once for the actual editing form). There should be a way inside sfgFormPrinter->formHTML to 'un-standardize' the form inputs.
Comment 5 Yaron Koren 2012-01-25 22:07:56 UTC
Thanks for this great patch! I just added it in to Semantic Forms, although I made some changes to the code layout, the display of the preview, and the wording, to try to make the look more consistent with MediaWiki's standard appearance. Please let me know if you disagree with any of my changes - I'm marking this as "fixed", but we can continue the conversation here.

By the way, it doesn't look like modifying the form to get rid of wpSave or wpSummary is necessary - when I try it, at least, clicking on those buttons doesn't do anything anyway.
Comment 6 Solitarius 2012-02-10 20:14:08 UTC
Thanks you very much for commiting the patch to SVN. This addition to the code even made it to our internal corporate bulletin as a important improvement. :)
Comment 7 Yaron Koren 2012-02-10 20:39:55 UTC
Sweet! It's a real win-win. I'm starting to use this myself, now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links