Last modified: 2013-07-25 07:08:13 UTC
The new FileBackend code (merged in r106752) broke the file handling of DumpHTML completely. With current trunk, no referenced images are added to the HTML dump at all. Whenever the dumper encounters an image, the following error occurs: PHP Warning: file_exists(): Unable to find the wrapper "mwstore" - did you forget to enable it when you configured PHP? in /srv/www/mediawiki/extensions/DumpHTML/dumpHTML.inc on line 1295 Can someone knowledgeable about the new FileBackend code please fix this?
Try testing it after r110703.
Thanks a lot, it's working fine now! I needed just one additional patch: --- a/dumpHTML.inc +++ b/dumpHTML.inc @@ -1354,6 +1354,7 @@ class DumpHTML_ProxyFile { if ( isset( $thumb->url ) ) { $thumb->url = $this->fixURL( $thumb->url ); } + $thumb->file = $this; return $thumb; } Without this, the links on image pages to the original image had an absolute path. I think this is the correct fix, but it would be nice if you could check and then commit it.
That looks OK to commit.
(In reply to comment #3) > That looks OK to commit. Did you commit this? Could you tag the revision 1.19?
To fix this bug, we need: - backport r110703 in REL1_19 - apply the fix from comment 2 in trunk and REL1_19 - test dumpHTML in REL1_19
I would like to test, as I am affected by this bug.
You can checkout https://gerrit.wikimedia.org/r/#/c/17697/, which fixes this bug and a bunch of other issues with the DumpHTML extension. The change is not yet merged into the DumpHTML master branch, because it needs review by someone else than me (the author of the change).
(In reply to comment #7) > You can checkout https://gerrit.wikimedia.org/r/#/c/17697/, which fixes this > bug and a bunch of other issues with the DumpHTML extension. The change is > not > yet merged into the DumpHTML master branch, because it needs review by > someone > else than me (the author of the change). This was merged.
