Last modified: 2014-07-24 20:58:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35978, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33978 - FeaturedFeeds extension: Set feed limit for monthly featured articles on la.wikipedia
FeaturedFeeds extension: Set feed limit for monthly featured articles on la.w...
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: This, that and the other (TTO)
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-26 21:47 UTC by uv.wiki
Modified: 2014-07-24 20:58 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
see comment #c0 (428 bytes, patch)
2012-01-26 21:47 UTC, uv.wiki
Details

Description uv.wiki 2012-01-26 21:47:11 UTC
Created attachment 9916 [details]
see comment #c0

la.wikipedia has monthly featured articles. The proposed patch (untested) sets the 'limit' to 180 (= 6 months = 6 feed entries), for la.wikipedia on WMF only.
Comment 1 Sumana Harihareswara 2012-01-26 21:56:06 UTC
uv.wiki, thank you for the patch!

I have added the keyword "need-review" to indicate that the patch needs to be reviewed.  Next time, you can do this yourself when you attach the patch, to save time.

Thanks again.
Comment 2 Sumana Harihareswara 2012-02-10 20:38:44 UTC
uv.wiki, there's been a bit of a delay in the review of patches here -- as we prepare to get a new version out, we're in a "code slush" during which we concentrate on reviewing code that has already been committed to our source code repository (see http://thread.gmane.org/gmane.science.linguistics.wikipedia.technical/57950 for more details).  But we'll try to respond to your contribution soon.  My apologies for the wait.
Comment 3 Andre Klapper 2013-02-13 12:20:10 UTC
This seems to be about a configuration change for deployment.
Wondering if either FeaturedFeeds' codebase is very WM-centric, or if this should be moved to Wikimedia's site configuration component instead.

@uv.wiki: 
Sorry that there has been no patch review so far.
If this is still wanted, you are welcome to use Developer access
  https://www.mediawiki.org/wiki/Developer_access
to submit this as a Git branch directly into Gerrit:
  https://www.mediawiki.org/wiki/Git/Tutorial
Putting your branch in Git makes it easier to review it.
Comment 4 uv.wiki 2013-02-24 21:26:58 UTC
Moving to Wikimedia's site configuration component as suggested by Andre Klapper in #c3
Comment 5 Andre Klapper 2013-02-25 14:49:42 UTC
Looking at the patch, I was wrong (sorry). Moving back...
Comment 6 Bingle 2014-06-12 20:29:18 UTC
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/XTM2RRap
Comment 7 This, that and the other (TTO) 2014-07-07 07:28:46 UTC
The file FeaturedFeedsWMF.php has now moved to Wikimedia config (where it should have been all along).
Comment 8 This, that and the other (TTO) 2014-07-07 07:55:09 UTC
I suppose I should ask: Is this bug still relevant? Featured feeds don't appear to be working at all on Latin Wikipedia.

It really makes me sad to see simple requests like this sit untouched for over 2 years. Sorry for the extremely long wait.
Comment 9 uv.wiki 2014-07-08 19:48:31 UTC
Yes, the bug is still relevant. I would be happy to make FeaturedFeeds work for la.wikipedia featured articles once this bug is fixed (and once I will return from my short wikibreak, which will happen in a few days' time).
Comment 10 Gerrit Notification Bot 2014-07-12 11:41:30 UTC
Change 145760 had a related patch set uploaded by TTO:
Add lawiki featured feed settings

https://gerrit.wikimedia.org/r/145760
Comment 11 Gerrit Notification Bot 2014-07-24 18:37:33 UTC
Change 145760 merged by Reedy:
Add lawiki featured feed settings

https://gerrit.wikimedia.org/r/145760
Comment 12 Tomasz W. Kozlowski 2014-07-24 20:58:15 UTC
This has now been merged and deployed to the production cluster by Reedy (thank you!).

Many thanks to TTO for taking the time to fix this bug.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links