Last modified: 2012-06-08 11:10:40 UTC
I think since Version 1.7 "intro", "outro" and "default" don't trim() their values anymore before applying them. This makes the replacement of "_" against " " useless. So either they should trim() or the replacement should be omitted. It would also be enough to just replace leading and tailing "_" but not those in the middle. There is also a replacement of "_" happening for the 'default' parameter, I can't see why. It might be worth re-thinking the whole concept of these parameters. On the other hand, they are in use for a long time already and it might break stuff changing their behavior more radically. Anyway, there is also Bug 28075 which suggests to expand the 'default' only when needed. I suggest doing the same for 'intro' and 'outro' and perhaps moving the parameter handling to the parser functions instead of handling it within the SMWResultPrinter. 'Intro' and 'Outro' are getting handled twice right now it seems, for one in SMWQueryProcessor::getResultFromQuery() but also in SMWResultPrinter
