Last modified: 2012-06-06 17:21:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36041, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34041 - Image page provides links to image resolutions greater than those supported by image scalars
Image page provides links to image resolutions greater than those supported b...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Tim Starling
: platformeng
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-30 15:10 UTC by とある白い猫
Modified: 2012-06-06 17:21 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description とある白い猫 2012-01-30 15:10:28 UTC
http://commons.wikimedia.org/wiki/File:Iridescent_Glory_of_Nearby_Helix_Nebula.jpg

If you take a look at the above file you will see 

"Size of this preview: 240 × 240 pixels. Other resolutions: 480 × 480 pixels | 600 × 600 pixels | 768 × 768 pixels | 1,024 × 1,024 pixels | 10,000 × 10,000 pixels."

The last item (10,000 × 10,000 pixels) doesn't render anything as wikimedia settings chops rescaling at 2,000 × 2,000 pixels I believe, which is fine. Therefore the presence of 10,000 × 10,000 pixels is problematic since it renders nothing (or it renders an error).
Comment 1 Antoine "hashar" Musso (WMF) 2012-02-01 13:25:48 UTC
I though those links were supposed to produce a client side upscaling (i.e.: a 800x800 picture requested at 10000x10000) would produce code such as <img width="10000" height="10000" ...
Comment 2 Bawolff (Brian Wolff) 2012-02-01 15:12:40 UTC
(In reply to comment #1)
> I though those links were supposed to produce a client side upscaling (i.e.: a
> 800x800 picture requested at 10000x10000) would produce code such as <img
> width="10000" height="10000" ...

The link is directly to the image file, not an html file containing an <img> tag.
Comment 3 Chad H. 2012-02-01 15:55:40 UTC
Isn't this done locally on commons with some JS?
Comment 4 Bawolff (Brian Wolff) 2012-02-01 21:43:22 UTC
(In reply to comment #3)
> Isn't this done locally on commons with some JS?

I thought so to, but then i viewed the page in lynx and it was still there - so apparently not.
Comment 5 Lejonel 2012-02-11 12:24:03 UTC
This is easy to fix by changing default value of $wgImageLimits in DefaultSettings.php (or locally in Wikimedias local settings file). 

$wgImageLimits is also the options for the user preference for image preview size on file description pages. But a 10000x10000px option is not very useful for that either, since it will not be rendered.
Comment 6 Lejonel 2012-02-11 12:45:07 UTC
(In reply to comment #5)
Actually it can be useful since it displays the full resolution of images smaller than 10000x10000.
Comment 7 Bawolff (Brian Wolff) 2012-02-11 20:22:47 UTC
(In reply to comment #5)
> This is easy to fix by changing default value of $wgImageLimits in
> DefaultSettings.php (or locally in Wikimedias local settings file). 
> 
> $wgImageLimits is also the options for the user preference for image preview
> size on file description pages. But a 10000x10000px option is not very useful
> for that either, since it will not be rendered.


Seems a weird choice for a default then (and it seems to go way back to r5195).

(In reply to comment #6)
> (In reply to comment #5)
> Actually it can be useful since it displays the full resolution of images
> smaller than 10000x10000.

We should have a non-hacky way of specifying this in user preferences then.
Comment 8 Antoine "hashar" Musso (WMF) 2012-04-23 21:56:54 UTC
The size limit was introduced in 2004 by Jens Frank with commit 7be49919836a38

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=commit;h=7be49919836a3871102cc1375733c35e82e11b19

I am pretty sure 10k x 10k was, as Lejonel said, meant to display images in full resolution.  At that time it was rare to have image bigger than 4k by 4k, most people probably had 1024x768 screens.
Comment 9 Tim Starling 2012-04-23 22:35:27 UTC
Removed the 10000x10000 option from $wgImageLimits in proposed change f044a3745919244c84450ba70d69473df3b84813
Comment 10 Antoine "hashar" Musso (WMF) 2012-04-24 08:32:58 UTC
The patch removes the option from wgImageLimits which has some issues:

- as a side effect any users having that preference set (24k of them on enwiki) will be displayed a 320x240 picture as a fallback.

- max size will now be 1280x1024 which is not that big when you have a 24 - 27 inches monitor. That will also force a thumbnail generation for this users when they actually want the full sized picture.

- we need a release notes since any wiki that have set $wgDefaultUserOptions['imagesize'] to 5 would need to alter it.
Comment 11 とある白い猫 2012-05-07 11:39:33 UTC
When I click images now, I ALWAYS get the maximum resolution even if I click on 240x240 resolution. Something unintended is broken.
Comment 12 とある白い猫 2012-05-22 00:33:37 UTC
The introduced bug has not been resolved. It has made the resolution links (of any kind) useless.
Comment 13 Andre Klapper 2012-05-22 09:15:48 UTC
(In reply to comment #11)
> When I click images now, I ALWAYS get the maximum resolution even if I click on
> 240x240 resolution.

Cannot reproduce in Firefox 12 on Fedora 16 with the link in comment 0. 240x240 displays also that size. Please provide more information how to reproduce (browser? did you try another one?) and make sure that this is not a cache etc issue in your browser.
Comment 14 とある白い猫 2012-06-06 17:21:11 UTC
Hmm... It seems like it was chrome user settings which were magnifying images by %1500. Since the original issue is resolved and the issue I thought was an issue is invalid, I am closing this as resolved.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links