Last modified: 2013-10-23 18:17:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36114, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34114 - CSSMin function remap not respecting $embed
CSSMin function remap not respecting $embed
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.18.x
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-01 12:47 UTC by Gilles van den Hoven
Modified: 2013-10-23 18:17 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gilles van den Hoven 2012-02-01 12:47:22 UTC
The parameter list of CSSMin::Remap allows for the option $embed with which you can set if the embedding of images has to be done. Currently the $embed variable is overwritten at position 150 ($embed = $match['embed'][0];).

Suggestion:
Change the function params to this:
public static function remap( $source, $local, $remote, $embed_data = true )

-----
and at line 159-160, change:
-----
// Embedding requires a bit of extra processing, so let's skip that if we can
if ( $embed ) {

-----
to:
-----
// Embedding requires a bit of extra processing, so let's skip that if we can
if ( $embed_data && $embed ) {

This way, even if CSSMin finds /* @embed */ comments it can be overwritten for performance/size reasons.
Comment 1 Roan Kattouw 2012-02-02 10:31:36 UTC
Thanks for the patch, applied in r110557.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links