Last modified: 2013-10-23 18:17:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36125, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 34125 - Defines.php seems not to be loaded for maintenance scripts


Summary:	Defines.php seems not to be loaded for maintenance scripts

Status:	NEW

Product:	MediaWiki
Classification:	Unclassified
Component:	Maintenance scripts (Other open bugs)
Version:	1.18.x
Hardware:	All All

Importance:	Low minor (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-02-01 21:20 UTC by Sam Reed (reedy)
Modified:	2013-10-23 18:17 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2012-02-01 21:20:28 UTC

Using addwiki on WMF:

PHP Notice:  Use of undefined constant DBO_DEFAULT - assumed 'DBO_DEFAULT' in /home/wikipedia/common/wmf-config/db.php on line 121

Comment 1 Tyler Romeo 2013-02-11 22:32:23 UTC

Which maintenance script did this occur for? Because doMaintenance.php does load Defines.php (it does so right before loading DefaultSettings.php and whatnot).

Comment 2 Sam Reed (reedy) 2013-02-11 22:37:45 UTC

(In reply to comment #1)
> Which maintenance script did this occur for? Because doMaintenance.php does
> load Defines.php (it does so right before loading DefaultSettings.php and
> whatnot).

(In reply to comment #0)
> Using addwiki on WMF:

Comment 3 Tyler Romeo 2013-02-11 22:58:04 UTC

(In reply to comment #2)
> (In reply to comment #1)
> > Which maintenance script did this occur for? Because doMaintenance.php does
> > load Defines.php (it does so right before loading DefaultSettings.php and
> > whatnot).
> 
> (In reply to comment #0)
> > Using addwiki on WMF:

:P Maybe I'm missing something, but I can't find that maintenance script. Is it WMF specific? Or does it have a different name in git?

Comment 4 Sam Reed (reedy) 2013-02-11 23:16:58 UTC

(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > Which maintenance script did this occur for? Because doMaintenance.php does
> > > load Defines.php (it does so right before loading DefaultSettings.php and
> > > whatnot).
> > 
> > (In reply to comment #0)
> > > Using addwiki on WMF:
> 
> :P Maybe I'm missing something, but I can't find that maintenance script. Is
> it
> WMF specific? Or does it have a different name in git?

It's very WMF specific, to the extent it's in extensions/WikimediaMaintenance ;)


I have added a conditional define block to the currently used db files: if ( !defined( 'DBO_DEFAULT' ) ) { define( 'DBO_DEFAULT', 16 ); }

In WMF world LocalSettings.php includes CommonSettings.php, which then includes the relevant db file.

I guess it should probably be moved to another component. It's really not of any high priority, as the files can easily be fixed up with the conditional defines.

Comment 5 Andre Klapper 2013-02-12 10:46:00 UTC

(In reply to comment #4)
> It's very WMF specific, to the extent it's in extensions/WikimediaMaintenance

Shall we move this report to that product/component combo in Bugzilla then?

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links