Last modified: 2014-02-12 23:53:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36145, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34145 - MobileFrontend extension should not be tied to WMF caching infrastructure
MobileFrontend extension should not be tied to WMF caching infrastructure
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Low normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-02 01:10 UTC by Arthur Richards
Modified: 2014-02-12 23:53 UTC (History)
13 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Arthur Richards 2012-02-02 01:10:06 UTC
Right now, the MobileFrontend has hard-coded values for WMF caching infrastructure. These should be made configurable.
Comment 1 Daniel Friesen 2012-02-02 02:34:47 UTC
I believe varnish is configured to pretend that "Host: en.wikipedia.org" when in reality it's "Host: en.m.wikipedia.org".

I'd like to see that dropped and have MobileFrontend explicitly test to see if it's on the mobile site.

WURFL is included into MobileFrontend. Perhaps some more work on that should be done so that WURFL can be used inside Varnish, and also inside php as a fallback.

It would also be nice for one version of the mobile device redirection from the desktop to mobile version to be built-in to MobileFrontend.
Comment 2 Patrick Reilly 2012-02-02 19:05:08 UTC
(In reply to comment #1)
> I believe varnish is configured to pretend that "Host: en.wikipedia.org" when
> in reality it's "Host: en.m.wikipedia.org".

This is not exactly the case, but close.

> 
> I'd like to see that dropped and have MobileFrontend explicitly test to see if
> it's on the mobile site.

We don't want to go past the caching layer for this test.

> 
> WURFL is included into MobileFrontend. Perhaps some more work on that should be
> done so that WURFL can be used inside Varnish, and also inside php as a
> fallback.

We are working on integrating WURFL or something similar into the caching layer.  

> 
> It would also be nice for one version of the mobile device redirection from the
> desktop to mobile version to be built-in to MobileFrontend.

It is currently built-in you just need to change a few things like in this gist:
https://raw.github.com/gist/1590648/86abdf93a99876c609862b28f8dae1b488bded03/MobileFrontend.php

But, I agree it should be streamlined and made consistant throughout implementations.
Comment 3 Daniel Friesen 2012-02-02 19:47:40 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > I believe varnish is configured to pretend that "Host: en.wikipedia.org" when
> > in reality it's "Host: en.m.wikipedia.org".
> 
> This is not exactly the case, but close.
> 
> > 
> > I'd like to see that dropped and have MobileFrontend explicitly test to see if
> > it's on the mobile site.
> 
> We don't want to go past the caching layer for this test.
I mean I want MobileFrontend to test for en.m.wikipedia.org for assertion that it's on the mobile domain instead of testing for X-Device which will only be set by varnish. They have the same caching implications.

> > 
> > WURFL is included into MobileFrontend. Perhaps some more work on that should be
> > done so that WURFL can be used inside Varnish, and also inside php as a
> > fallback.
> 
> We are working on integrating WURFL or something similar into the caching
> layer.  
> 
> > 
> > It would also be nice for one version of the mobile device redirection from the
> > desktop to mobile version to be built-in to MobileFrontend.
> 
> It is currently built-in you just need to change a few things like in this
> gist:
> https://raw.github.com/gist/1590648/86abdf93a99876c609862b28f8dae1b488bded03/MobileFrontend.php
> 
> But, I agree it should be streamlined and made consistant throughout
> implementations.
Comment 4 Diederik van Liere 2012-02-02 20:10:02 UTC
Maybe we can embed wurfl in varnish? (see http://www.enrise.com/2011/02/mobile-device-detection-with-wurfl-and-varnish/ for a lousy example)
Comment 5 Arthur Richards 2012-02-16 22:20:12 UTC
WURFL related stuff brought up in these comments is outside the scope of the issue initially raised - the fact that there are hard-coded values for WMF caching infrastructure in the MobileFrontend code. This should now be resolved in r111689.
Comment 6 Arthur Richards 2012-02-16 22:21:28 UTC
(In reply to comment #5)
> WURFL related stuff brought up in these comments is outside the scope of the
> issue initially raised - the fact that there are hard-coded values for WMF
> caching infrastructure in the MobileFrontend code. This should now be resolved
> in r111689.

I forgot to mention - please feel free to open up a new bug or new bugs for the other issues mentioned in the above comments.
Comment 7 Patrick Reilly 2012-02-17 12:37:09 UTC
This is now fixed as of r111746.

— Patrick

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links