Last modified: 2013-02-14 22:06:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36158, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 34158 - Fatal error when posting code review comment
Fatal error when posting code review comment
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-02-02 11:54 UTC by Niklas Laxström
Modified: 2013-02-14 22:06 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Niklas Laxström 2012-02-02 11:54:35 UTC 
4 PHP Catchable fatal error:  Method MailAddress::__toString() must return a string value in /usr/local/apache/common-local/php-1.18/includes/UserMailer.php on line 128

https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108768
Comment 1 Antoine "hashar" Musso (WMF) 2012-02-02 14:11:47 UTC 
That is a bug in CodeReview. At some point it tries to send email to a null user which produce a null email address. That throw the fatal error in 1.18.
Comment 2 Antoine "hashar" Musso (WMF) 2012-02-02 14:34:01 UTC 
workaround backported from trunk to 1.18wmf1 with r110571

Should throw an exception instead to get a stack trace.
Comment 3 Sam Reed (reedy) 2012-02-02 23:53:25 UTC 
Weird...

$user->canReceiveEmail() should prevent this from happening...
Comment 4 Nemo 2013-02-14 22:06:49 UTC 
(In reply to comment #2)
> workaround backported from trunk to 1.18wmf1 with r110571
> 
> Should throw an exception instead to get a stack trace.

Didn't this fix it? Anyway 1.18 is unsupported now and CR is dead.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links