Last modified: 2012-02-11 18:11:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36198, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 34198 - first item in the history shows no information about its size
first item in the history shows no information about its size
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.20.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-02-04 11:14 UTC by Umherirrender
Modified: 2012-02-11 18:11 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
show always a size (3.48 KB, patch)
2012-02-11 14:20 UTC, Umherirrender 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Umherirrender 2012-02-04 11:14:13 UTC 
With MediaWiki 1.19 the history page was changed from showing the size to showing the diff and giving the size in the tooltip.

But now the first item in the history has no information about it size.

New pages in the RecentChanges getting the whole size as added, maybe the first item can get this also?

Thanks.
Comment 1 Umherirrender 2012-02-04 12:28:57 UTC 
On Special:Contributions the new revisions has the same problem. Maybe also use the size of that page as added size?
Comment 2 Mark A. Hershberger 2012-02-08 18:30:58 UTC 
Can you provide a link to this on en.wikimedia.beta.wmflabs.org?  I'm not seeing this right now.
Comment 3 Umherirrender 2012-02-08 20:49:41 UTC 
You can look at the history of a page[1]: 

18:48, 8 February 2012‎ MarkAHershberger (Talk | contribs)‎ . . (+6)‎ . . (undo) 
18:48, 8 February 2012‎ MarkAHershberger (Talk | contribs)‎ (←Created page with 'i̇̃') 

The first item has a size (+6) the other does not.
Looking at Special:Contributions [2]:

18:48, 8 February 2012 (diff | hist) . . (+6)‎ . . Sandbox ‎ (top) 
18:48, 8 February 2012 (diff | hist) N Sandbox ‎ (←Created page with 'i̇̃') 

The first item has a size (+6) the other does not.
Looking at recentchanges [3]:

8 February 2012
(diff | hist) . . Sandbox‎; 18:48 . . (+6)‎ . . ‎MarkAHershberger (Talk | contribs)‎
(diff | hist) . . N Sandbox‎; 18:48 . . (+9)‎ . . ‎MarkAHershberger (Talk | contribs)‎ (←Created page with 'i̇̃')

Both items has a size

[1] http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Sandbox&action=history
[2] http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Contributions/MarkAHershberger&offset=20120208184900&limit=2&target=MarkAHershberger
[3] http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:RecentChanges&from=20120208184700
Comment 4 Mark A. Hershberger 2012-02-09 16:34:11 UTC 
Could you provide a patch for this? (Asking b/c you've done patches in
the past and may be able to track this down more quickly.)
Comment 5 Umherirrender 2012-02-11 14:20:49 UTC 
Created attachment 9985 [details]
show always a size

I have create a patch, which change the two places in HistoryAction and SpecialContributions: If the prevRev or the parentLen not set, use a 0 for the old size.

The patch also improves the use of LinkBatch on that two pages.

Feel free to modify the patch.
Comment 6 Mark A. Hershberger 2012-02-11 18:11:35 UTC 
r111251
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links