Last modified: 2012-02-24 02:52:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36207, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 34207 - Opening a saved page crashes the app
Opening a saved page crashes the app
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Generic (Other open bugs)
1.0.0 (Android)
All All
: Normal normal
: ---
Assigned To: Yuvi Panda
:
Depends on:
Blocks: 31805
  Show dependency tree / graph
 
Reported: 2012-02-05 08:32 UTC by Yuvi Panda
Modified: 2012-02-24 02:52 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: Android
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Yuvi Panda 2012-02-05 08:32:18 UTC 
Currently, saving a page makes the app crash.

Debugging points me to a segfault when we use jQuery AJAX on a file:/// url.
Comment 1 Yuvi Panda 2012-02-05 08:44:07 UTC 
Upgrading to PhoneGap 1.4.1 does not fix the issue. Need to bisect and figure out which exactly caused this issue.
Comment 2 Yuvi Panda 2012-02-05 09:34:22 UTC 
Git bisected my way to find the offending commit: 237b09ca31d7e71771af1c60f5f7d3fb8cef3440

It was when we moved off zepto into jQuery, so the issue *is* with jQuery. Sigh.

Also there was this very helpful comment in the commit message:

> Note: SavedPages no longer work. Yay!

So if I had remembered the commit messages I wrote, I wouldn't have had to spend the hour using git bisect. #facepalm
Comment 3 Yuvi Panda 2012-02-07 07:47:09 UTC 
Fixed in b0296f6b4c35c84aea1ff552e531042f473640fa by using Zepto.js just for the Ajax.

Highly hacky solution, but best I could do for now. Two days of trying to debug jQuery seem to have failed (it seems to crash a while after the .send XHR call has been called). Either need to figure out why this is a problem with jQuery and fix that, or use raw XHR ourselves.
Comment 4 Yuvi Panda 2012-02-15 19:26:42 UTC 
Closing for now, since this 'works'. Need to re-open bug about moving off zepto.js.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links