Last modified: 2014-09-23 19:49:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36229, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 34229 - Make $wgPdfBookTab configurable, allow export of pictures in private environments
Make $wgPdfBookTab configurable, allow export of pictures in private environm...
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
PdfBook (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-02-06 17:19 UTC by Johannes Weberhofer
Modified: 2014-09-23 19:49 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
PDFBook enhancements (2.39 KB, patch)
2012-02-06 17:19 UTC, Johannes Weberhofer 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Johannes Weberhofer 2012-02-06 17:19:28 UTC 
Created attachment 9960 [details]
PDFBook enhancements

The attached patch will

1) Allow the setting of $wgPdfBookTab in LocalSettings.php, keeping the "false" setting per default.

2) Make the setting for html-pages as "single" per default. 

3) Allow pictures from private wikis to be exported using direct file-system links to the pictures instead of http-links.
Comment 1 Sam Reed (reedy) 2012-02-06 17:36:12 UTC 
35	if ( !isset( $wgPdfBookTab ) ) {
36		$wgPdfBookTab = false;
37	}

Don't do that. See http://www.mediawiki.org/wiki/Register_globals
Comment 2 Johannes Weberhofer 2012-02-06 18:45:28 UTC 
Thank you for the note. You are right. Feature (1) only needed to be documented, what I did now.
Comment 3 Sumana Harihareswara 2012-02-10 20:33:08 UTC 
Johannes, thanks for the patch.  It looks like Sam gave you some feedback on what you need to fix, so I'm marking this reviewed -- please do respond with an updated patch if you have time.  Thank you!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links