Last modified: 2014-09-26 20:25:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36282, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 34282 - Non-conventional name of include file.
Non-conventional name of include file.
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Comments (Other open bugs)
unspecified
All All
: Lowest trivial (vote)
: ---
Assigned To: Jack Phoenix
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-02-08 21:41 UTC by Van de Bugger
Modified: 2014-09-26 20:25 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Van de Bugger 2012-02-08 21:41:29 UTC 
Hi, nice extension, thanks. But: extension name is "Comments" while file to include name is "Comment.php". Not  big deal, but it is unconventional, usually the file to include has the same name as extension itself. Could you please rename file to "Comments.php"?
Comment 1 Jack Phoenix 2012-02-09 14:59:19 UTC 
It's suckage, but it's <s>old</s> ancient suckage. I'm not fond of silly compatibility files (like extensions/Renameuser/SpecialRenameuser.php), and there are wikis out there using the Comments extension, which is why I (still!) haven't gotten around renaming the main setup file...I guess we just need to break the wikis, but after it's done, there's no need to rename the setup file. :)

tl,dr: will do this later on, but no idea when.
Comment 2 Van de Bugger 2012-02-09 17:55:37 UTC 
Let me proposed approach... You could rename include file to "Comments.php", and create a special stub "Comment.php" for backward compatibility:

require_once( dirname( __FILE__ ) . "/Comments.php" );

Later you could drop it...
Comment 3 Jack Phoenix 2014-09-26 20:25:45 UTC 
This appears to have been done in August 2014 in Change-Id: Ic3731e1858d1ba891392d5787120eff2f97d9858
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links