Last modified: 2013-11-13 22:52:31 UTC
Re-submitting request for pinch zoom. Bug 31765 was closed because a font size setting now exists, but I still believe zoom is important. I don't think this is a nice-to-have feature, I think we really need this. Overriding font size globally just doesn't cut it. People actually avoid the app and use the browser because this doesn't work.
+1 Zoom is important. It's worth noting that currently the page 'List of moments of inertia' cannot be zoomed so the table cannot be read.
Jon: This was set to highest priority more than two months ago. Has any work on this happened, or is it in progress? If not I'd set a lower priority.
We get a lot of people complaining about this, however my personal focus has shifted from the mobile app to the mobile site. Would be extremely happy if someone was able to send a patch to fix this (I still think it is a high priority)!
Hey Jon, I have worked around this bug, and have implemented the functionality, but I am waiting for my developer access request to get approved before I could submit the patch to Gerrit. Also I had to discuss the implementation, as currently my fix zooms the whole viewport, which includes the top bar containing the search bar as well. I was currently looking for a way to only zoom the content and not the whole viewport. What do you suggest about this ??
Hi Praveen! That's great! Even zooming everything (including search box) is a big improvement and is probably the right thing to do - why wouldn't we zoom the search result box? There is no need to have a gerrit account to edit the Wikipedia app - just sign up to github.com and send a pull request to https://github.com/wikimedia/WikipediaMobile ! Any discussion that needs to occur can occur on your pull request!
Just created Praveen's developer access account for Gerrit -- but if I recall correctly, to change our Android app you'd submit a pull request to https://github.com/wikimedia/WikipediaMobile , which means you need a GitHub.com account. More details: https://www.mediawiki.org/wiki/Mobile/PhoneGap/Tutorial
(In reply to comment #3) > (I still think it is a high priority)! I see. Thanks for explaining! Setting this to "High", as "Highest" priority should be reserved for bugs that someone needs to drop what they're doing and address really soon (2 or 3 days).
Hey Jon, I discussed my current fix with Yuvipanda. He pointed me towards a few resources that implement zooming the content only and not the whole viewport. I am currently working to achieve the same and will submit a pull request as soon as possible.
This should be much, much, MUCH easier to implement on the new apps we're starting, as we can simply let the web view handle zoom and all our app chrome is outside of that.
Change 95271 had a related patch set uploaded by Yuvipanda: Enable pinch-zooming of article contents https://gerrit.wikimedia.org/r/95271
Change 95271 merged by Brion VIBBER: Enable pinch-zooming of article contents https://gerrit.wikimedia.org/r/95271
https://gerrit.wikimedia.org/r/#/c/95285/ also added this to the new iOS codebase.
