Last modified: 2012-02-09 18:53:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36301, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 34301 - Comments: Vote buttons for users without "comment" right.
Comments: Vote buttons for users without "comment" right.
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Comments (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Jack Phoenix
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-02-09 18:13 UTC by Van de Bugger
Modified: 2012-02-09 18:53 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Patch for the option #1. (360 bytes, patch)
2012-02-09 18:19 UTC, Van de Bugger 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Van de Bugger 2012-02-09 18:13:10 UTC 
A user without "comment" right cannot leave comments, no editor field, no "Reply" links, but vote buttons are visible (not sure what is reaction to a click, thought). 

I see two variants:

1. Keep the extension simple: Users without "comment" right cannot vote => vote buttons should be hide (and server should not accept votes from such users).

2. Increase complexity (and flexibility): We can introduce another right, "vote", to control voting, and show/hide buttons based on this right.

Your choice?
Comment 1 Van de Bugger 2012-02-09 18:19:34 UTC 
Created attachment 9974 [details]
Patch for the option #1.

The patch for option #1 is trivial.
Comment 2 Mark A. Hershberger 2012-02-09 18:53:07 UTC 
r111059
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links