Last modified: 2012-02-23 22:53:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36309, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34309 - [SF] 2.4; Add new parser function #queryformlink
[SF] 2.4; Add new parser function #queryformlink
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SemanticForms (Other open bugs)
unspecified
All All
: Unprioritized enhancement (vote)
: ---
Assigned To: Yaron Koren
:
: 33425 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-09 23:19 UTC by MWJames
Modified: 2012-02-23 22:53 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch add's a new parser #querylink (1.92 KB, application/octet-stream)
2012-02-09 23:19 UTC, MWJames
Details

Description MWJames 2012-02-09 23:19:05 UTC
Created attachment 9977 [details]
Patch add's a new parser #querylink

This patch add's a new parser #querylink that allows the generate RunQuery Special page links using the same parameter notions as in #formlink.

Instead of generating links via [1] using #querylink [2] creates the same result and additionally allows to run the query as popup without leaving the current page content.

[1] [{{fullurl:Special:RunQuery/DMS|wpRunQuery=true&Query/DMS%5Blimit%5D=15}} Browse DMS]

[2] {{#querylink:form=DMS|link text=Browse DMS|query string=wpRunQuery=true&Query/DMS[limit]=15|popup}}
Comment 1 badon 2012-02-10 00:40:35 UTC
Thanks for this, MWJames! I'm marking this as a duplicate for a previous enhancement request, and I'm linking to your patch on it too.

*** This bug has been marked as a duplicate of bug 33425 ***
Comment 2 MWJames 2012-02-10 00:51:44 UTC
Even though this patch is related to the #formlink parser bug 33425 discussion, this bug was created with the intention to apply a patch for SF 2.4+ which adds new functionality and is therefore a tracking instrument rather than to discuss functionality.

One's the patch has been reviewed and is released it can be closed but not before that.
Comment 3 badon 2012-02-10 01:19:35 UTC
I don't quite understand, but I think you're talking about some sort of personal principle you have. Either way, I'm fine leaving this open since it is slightly different from bug 33425. Once again, thanks for putting that together.
Comment 4 MWJames 2012-02-20 17:20:35 UTC
r111872 includes proposed changes to the new parser function #queryformlink
Comment 5 MWJames 2012-02-20 17:26:16 UTC
see also r111940 which disables additional queries in case of popup
Comment 6 Yaron Koren 2012-02-22 03:27:18 UTC
*** Bug 33425 has been marked as a duplicate of this bug. ***
Comment 7 s7eph4n 2012-02-23 13:07:24 UTC
There is something funny going on there. When running runJobs.php I get a warning:
"" is not a valid magic word for "queryformlink"

Not sure where it comes from.
Comment 8 MWJames 2012-02-23 13:22:31 UTC
I think nikerabbit tried to solve this with r112191.
Comment 9 s7eph4n 2012-02-23 13:34:38 UTC
Indeed, that fixes it. Closing again.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links