Last modified: 2013-01-11 19:28:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36339, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34339 - ResourceLoader checks touched date twice for some pages
ResourceLoader checks touched date twice for some pages
Status: NEW
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.20.x
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy, performance
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-11 19:59 UTC by db [inactive,noenotif]
Modified: 2013-01-11 19:28 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description db [inactive,noenotif] 2012-02-11 19:59:03 UTC
For modules with js and css pages, the ResourceLoader is checking the touched date twice for all pages of that module. The first time, when building the CSS and the second time, when building the scripts.

For example:
SELECT page_namespace,page_title,page_touched FROM `page` WHERE (page_namespace = '8' AND page_title IN ('Common.js','Common.css','Vector.js','Vector.css','Print.css') )
Callers:
MediaWiki::run/MediaWiki::main/MediaWiki::finalCleanup/OutputPage::output/SkinTemplate::outputPage/Skin::bottomScripts/OutputPage::getBottomScripts/OutputPage::getScriptsForBottomQueue/OutputPage::makeResourceLoaderLink/ResourceLoaderWikiModule::isKnownEmpty/ResourceLoaderWikiModule::getTitleMtimes/DatabaseBase::select

SELECT page_namespace,page_title,page_touched FROM `page` WHERE (page_namespace = '8' AND page_title IN ('Common.js','Common.css','Vector.js','Vector.css','Print.css') )
Callers:
MediaWiki::run/MediaWiki::main/MediaWiki::finalCleanup/OutputPage::output/SkinTemplate::outputPage/OutputPage::headElement/OutputPage::buildCssLinks/OutputPage::makeResourceLoaderLink/ResourceLoaderWikiModule::isKnownEmpty/ResourceLoaderWikiModule::getTitleMtimes/DatabaseBase::select

This is the same for the group-*.js/.css pages (ResourceLoaderUserGroupsModule).

When the module only contains css pages, there is only one select (ResourceLoaderNoscriptModule)

So you have 5 queries for loggedin users. You can reduce this to 3, maybe combine all to one query? When this is already done in the ResourceLoader2, than mark this as FIXED.

Thanks.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links