Last modified: 2014-02-12 23:45:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36422, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34422 - MobileFrontend's expandable sections should be pure-JS
MobileFrontend's expandable sections should be pure-JS
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
Feature requests (Other open bugs)
unspecified
All All
: Unprioritized enhancement
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-15 18:45 UTC by Max Semenik
Modified: 2014-02-12 23:45 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Max Semenik 2012-02-15 18:45:41 UTC
Currently, this is done in PHP with supporting JS code for expanding. Not only this results in people with phones that WURFL detects as supporting JS, but in which JS is manually disabled not being able to read the collasped sections, but it also fragments cache.

Ideally, JS should do all the work which will also provide a nice fallback for phones without JS - no JS, no collapsed sections.
Comment 1 Brion Vibber 2012-02-16 00:08:59 UTC
bug 34025 looks like a dupe of this; there's some notes on how to accomplish it without text flashing.

bug 31011 requests sorta the opposite: avoid loading section contents at all until they're opened, to reduce data consumption when all sections aren't used.
Comment 2 Max Semenik 2012-02-16 09:36:01 UTC
What I'm asking for is to have page HTML not depend on JS presence, while bug 34025 discusses the particular case of JS disabled in a JS-aware browser.
Comment 3 Jon 2012-02-17 14:18:14 UTC
Unless I'm misunderstanding do r111733 and r111651 take care of this?
Comment 4 Max Semenik 2012-02-17 15:40:27 UTC
(In reply to comment #3)
> Unless I'm misunderstanding do r111733 and r111651 take care of this?

They're steps in the right direction, but ideally PHP shouldn't know at all if user agent supports JS or not - that is, the buttons should be generated in JS too.
Comment 5 Jon 2012-02-17 15:50:48 UTC
Oh I see!
Yes totally agree.
Comment 6 Jon 2012-02-23 15:27:23 UTC
Resolved in r112208

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links