Last modified: 2012-02-16 13:20:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36442, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34442 - Reviewer is still able to accept a message after changing it
Reviewer is still able to accept a message after changing it
Status: RESOLVED WORKSFORME
Product: MediaWiki extensions
Classification: Unclassified
Translate (Other open bugs)
unspecified
All All
: Low trivial (vote)
: ---
Assigned To: Niklas Laxström
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-16 12:23 UTC by Nemo
Modified: 2012-02-16 13:20 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nemo 2012-02-16 12:23:24 UTC
As in, if he doesn't reload Special:Translate after changing a message, the "Accept" button is still there, can be pressed, it says that the translation has been accepted and the action is logged.
This has no real consequences as the extension will correctly report the translation as unreviewed.

Might be related to the fact that the review is logged as action on the page rather than on a specific revision as mentioned on bug 34153?

Example:
https://translatewiki.net/w/i.php?title=Wikia%3ADump-database-info%2Fit&action=historysubmit&diff=3697310&oldid=3696533
https://translatewiki.net/w/i.php?title=Special:Log/Nemo_bis&dir=prev&offset=20120216120848&limit=1&type=&user=Nemo+bis
Comment 1 Siebrand Mazeland 2012-02-16 12:48:18 UTC
That's not a problem. You're accepting the previous version, and the current version (by "you") remains unreviewed.
Comment 2 Nemo 2012-02-16 13:20:44 UTC
I see. But usually I'm not allowed to review the previous version either, although that's because there's only one accept button.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links