Last modified: 2012-10-03 07:01:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36483, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34483 - Trailing whitespace not visible in code diffs
Trailing whitespace not visible in code diffs
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-17 21:19 UTC by Niklas Laxström
Modified: 2012-10-03 07:01 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Niklas Laxström 2012-02-17 21:19:29 UTC
The new styles don't highlight trailing whitespace like the old ones did.

bug 27375 looks related, but I'm sure this worked before.
Comment 1 Krinkle 2012-03-08 09:31:22 UTC
Has this gotten any better since then?
Comment 2 Krinkle 2012-03-08 09:31:33 UTC
Example rev ID would be nice
Comment 3 Mark A. Hershberger 2012-03-08 16:27:28 UTC
r110843 has trailing w/s right at the top
Comment 4 Chad H. 2012-03-08 17:35:26 UTC
(In reply to comment #3)
> r110843 has trailing w/s right at the top

I can see the trailing whitespace there...so what's the bug?
Comment 5 Krinkle 2012-03-16 08:47:30 UTC
To bug or not to bug?
Comment 6 Niklas Laxström 2012-03-16 11:49:39 UTC
It is highlighted (although very hard to see and only if the line has changed), it could be better.
Comment 7 Nemo 2012-10-03 06:51:16 UTC
Should it make a red rectangle as gerrit does?
Comment 8 Krinkle 2012-10-03 06:58:22 UTC
Fixed long ago in 27375. The change characters now have a colors background, so it can be seen.

Instead of two grey lines:
-          
+

It now has:
-[          ]
+

(rr110843 for example).

For other whitespace (not trailing whitespace), it could be improved, by putting &raquo » for tab and dot . for space, but that's beyond this bug. And not sure if anyone is willing to implement it, since very few people are still using svn CodeReview, most if migrated to Gerrit by now.
Comment 9 Nemo 2012-10-03 07:01:33 UTC
Thanks.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links