Last modified: 2012-02-24 01:50:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36541, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34541 - File link-feature should not allow external links
File link-feature should not allow external links
Status: NEW
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
unspecified
All All
: Lowest enhancement with 4 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-20 10:32 UTC by Steef
Modified: 2012-02-24 01:50 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Steef 2012-02-20 10:32:42 UTC
External links inside of files ([[File:...|link=http://...]]) have a high potenital of abuse, as the link itself is only shown in the browser's link-preview. If a transparent picture is used and positioned absolute, every click on the whole page would lead to the possible malicious link.

This happened in dewiki today: http://de.wikipedia.org/w/index.php?diff=prev&oldid=99889277 (Hidden by an admin)

Additionally, in contrast to normal links, where the reader knows, that it is an external link, most users of Wikipedia click on an image to get to the description page and aren't expecting to end on an external page.

So in my opinion this feature should be removed. If you need an external link on a file, it should be enough to put it in the caption.
Comment 1 Max Semenik 2012-02-20 11:05:05 UTC
Every feature can be abused in one or another way. Do you have an evidence that this is a widepread problem?
Comment 2 Harald Krichel 2012-02-20 11:32:06 UTC
Not yet a widespread problem, but a serious security flaw, which should be solved before it becomes a widespread problem.
Comment 3 Derk-Jan Hartman 2012-02-20 20:07:27 UTC
the {{click}} templates and ImageMap extension have the same 'problem'. It has always existed, it's just that it seems some nutjob has been using this a lot recently on wikipedia. en.wp has an editfilter for it at least.

Removing external links from images would break some things I suspect, but I have no idea of the exact impact.
Comment 4 Steef 2012-02-20 20:29:26 UTC
Editfilter is a short term solution but I think this should be addressed in the long run (also for imagemaps).

Some links will be broken if this is changed, but as most page that are likely to be a link target are also availible via the interwiki map (https://meta.wikimedia.org/wiki/Interwiki_map), this shouldn't be much of an issue.
Comment 5 Brion Vibber 2012-02-21 19:38:39 UTC
This feels like a WONTFIX to me.

External links on images are very handy for, say, download links, tools, links to other wiki sites, etc.
Comment 6 Harald Krichel 2012-02-21 19:41:38 UTC
The problem here is not that much the external link on a picture, but the possibility to create a transparent overlay link.
Comment 7 Brion Vibber 2012-02-21 19:51:37 UTC
Abuse of markup is always possible; that's why we have review and revert abilities.

What's at issue is not this feature, but ability to use a large portion of CSS to position things.

That's not likely to go away any time soon either, as all sorts of positioning hacks are used for maps and things legitimately.
Comment 8 Bergi 2012-02-24 01:50:23 UTC
This is obviosly WONTFIX, positioning is needed. We can't prevent people from generating overlays, or we would have to disable much css which breaks everything. Also, the problem is not specific to image links.

As far as we prevent xss attacks, there is no security issue. Malicous domains should get blacklisted, and both textual and image external links will respect that list.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links