Last modified: 2012-02-20 17:18:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36547, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 34547 - [[mw:extension:EmbedVideo]] generates HMTL instead of HTML on EmbedVideo.hooks.php line 117


Summary:	[[mw:extension:EmbedVideo]] generates HMTL instead of HTML on EmbedVideo.hook...

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Other (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	patch, patch-need-review

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-02-20 16:49 UTC by Carl Austin Bennett
Modified:	2012-02-20 17:18 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
trivial patch to change 'Hmtl' to 'Html' on line 117 of extensions/EmbedVideo/EmbedVideo.hooks.php (71 bytes, application/octet-stream) 2012-02-20 16:49 UTC, Carl Austin Bennett	Details
Add an attachment (proposed patch, testcase, etc.)

Description Carl Austin Bennett 2012-02-20 16:49:53 UTC

Created attachment 10052 [details]
trivial patch to change 'Hmtl' to 'Html' on line 117 of extensions/EmbedVideo/EmbedVideo.hooks.php

This code in extensions/EmbedVideo/EmbedVideo.hooks.php line 117 is generating PHP errors in the logfiles:

                   return Hmtl::rawElement(
	  	  	'object',

should presumably be:

                   return Html::rawElement(
	  	  	'object',

from https://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/EmbedVideo/EmbedVideo.hooks.php?annotate=111231 (117 	happy-melon 	99206)

Comment 1 Sam Reed (reedy) 2012-02-20 17:18:01 UTC

Yup, fixed in r111939

Thanks!

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links