Last modified: 2012-02-22 10:11:43 UTC
https://www.mediawiki.org/wiki/Special:Code/MediaWiki/111979 In this commit, one file was deleted, another added and two were changed.
(In reply to comment #0) > https://www.mediawiki.org/wiki/Special:Code/MediaWiki/111979 > > In this commit, one file was deleted, another added and two were changed. as far as I remember ...
Warning: array_map(): An error occurred while invoking the map callback in /home/reedy/mediawiki/trunk/extensions/CodeReview/backend/DiffHighlighter.php on line 39 Call Stack: 0.0007 649264 1. {main}() /home/reedy/mediawiki/trunk/phase3/index.php:0 0.2774 18533768 2. MediaWiki->run() /home/reedy/mediawiki/trunk/phase3/index.php:58 0.2775 18533768 3. MediaWiki->main() /home/reedy/mediawiki/trunk/phase3/includes/Wiki.php:502 0.2794 18723928 4. MediaWiki->performRequest() /home/reedy/mediawiki/trunk/phase3/includes/Wiki.php:592 0.2958 19414552 5. SpecialPageFactory::executePath() /home/reedy/mediawiki/trunk/phase3/includes/Wiki.php:263 0.3021 20301728 6. SpecialCode->execute() /home/reedy/mediawiki/trunk/phase3/includes/SpecialPageFactory.php:477 0.4801 34084976 7. CodeRevisionView->execute() /home/reedy/mediawiki/trunk/extensions/CodeReview/ui/SpecialCode.php:27 0.6896 35821536 8. CodeRevisionView->formatDiff() /home/reedy/mediawiki/trunk/extensions/CodeReview/ui/CodeRevisionView.php:171 0.6978 35934176 9. CodeDiffHighlighter->render() /home/reedy/mediawiki/trunk/extensions/CodeReview/ui/CodeRevisionView.php:476 0.6978 35934176 10. CodeDiffHighlighter->splitLines() /home/reedy/mediawiki/trunk/extensions/CodeReview/backend/DiffHighlighter.php:25 0.6980 35998672 11. array_map() /home/reedy/mediawiki/trunk/extensions/CodeReview/backend/DiffHighlighter.php:39 CodeDiffHighlighter::parseChunkDelimiter given an invalid chunk header: '@@ -1 +0,0 @@' Backtrace: #0 /home/reedy/mediawiki/trunk/extensions/CodeReview/backend/DiffHighlighter.php(146): CodeDiffHighlighter::parseChunkDelimiter('@@ -1 +0,0 @@') #1 /home/reedy/mediawiki/trunk/extensions/CodeReview/backend/DiffHighlighter.php(68): CodeDiffHighlighter->handleChunkDelimiter('@@ -1 +0,0 @@') #2 [internal function]: CodeDiffHighlighter->parseLine('@@ -1 +0,0 @@') #3 /home/reedy/mediawiki/trunk/extensions/CodeReview/backend/DiffHighlighter.php(39): array_map(Array, Array) #4 /home/reedy/mediawiki/trunk/extensions/CodeReview/backend/DiffHighlighter.php(25): CodeDiffHighlighter->splitLines('Index: trunk/ex...') #5 /home/reedy/mediawiki/trunk/extensions/CodeReview/ui/CodeRevisionView.php(476): CodeDiffHighlighter->render('Index: trunk/ex...') #6 /home/reedy/mediawiki/trunk/extensions/CodeReview/ui/CodeRevisionView.php(171): CodeRevisionView->formatDiff() #7 /home/reedy/mediawiki/trunk/extensions/CodeReview/ui/SpecialCode.php(27): CodeRevisionView->execute() #8 /home/reedy/mediawiki/trunk/phase3/includes/SpecialPageFactory.php(477): SpecialCode->execute('MediaWiki/11197...') #9 /home/reedy/mediawiki/trunk/phase3/includes/Wiki.php(263): SpecialPageFactory::executePath(Object(Title), Object(RequestContext)) #10 /home/reedy/mediawiki/trunk/phase3/includes/Wiki.php(592): MediaWiki->performRequest() #11 /home/reedy/mediawiki/trunk/phase3/includes/Wiki.php(502): MediaWiki->main() #12 /home/reedy/mediawiki/trunk/phase3/index.php(58): MediaWiki->run() #13 {main}
Created attachment 10054 [details] difff
The number of lines is optional in a chunk delimiter. The following lines are valid too in addition of '@@ -l,s +l,s @@': @@ -l,s +l @@ @@ -l +l,s @@ @@ -l +l @@ r112096 is hacking support for it
Merged to 1.19wmf1 with r112098 and deployed live. I have managed to access https://www.mediawiki.org/w/index.php?title=Special:Code/MediaWiki/111979&path=