Last modified: 2014-01-05 05:02:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36572, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34572 - CentralNotice load fails on test2.wikipedia.org, shows JS errors in IE 7
CentralNotice load fails on test2.wikipedia.org, shows JS errors in IE 7
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://test2.wikipedia.org/wiki/Main_...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-21 21:17 UTC by Brion Vibber
Modified: 2014-01-05 05:02 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2012-02-21 21:17:38 UTC
Broken out from bug 34458:

(In reply to bug 34458 comment #8)
> as of Feb 21, both logged-in and not-logged-in users may edit on test2 using
> IE7. 
> 
> however, IE7 still shows the "Access denied" error for "Line 51" upon loading
> any page.   This is fairly annoying, especially for any users who may have
> "Always display... errors" checked in the browser.

Line: 51
Char: 3
Error: Access is denied.
Code: 0
URL: http://test2.wikipedia.org/wiki/Test_page

Line: 9
Char: 520
Error: Could not complete the operation due to error 80020101.
Code: 0
URL: http://test2.wikipedia.org/wiki/Main_Page


I see these in IE7, not in IE8. I See it on test2 but also on en.wikipedia.org, so this isn't 1.19-specific.
Comment 1 Chris McMahon 2012-02-21 21:22:06 UTC
which makes sense. Road identified Line 51: 

RoanKattouw: Line 51:
[4:46pm] RoanKattouw: </style><!--[if lt IE 7]><style
type="text/css">body{behavior:url("/w/skins-1.19/vector/csshover.min.htc")}</style><![endif]--></head>
Comment 2 Brion Vibber 2012-02-21 21:35:39 UTC
That should devolve to nothing on IE 7 though, since the comment says it's only for less than IE 7...?
Comment 3 Ryan Kaldari 2012-02-22 05:20:07 UTC
I suspect the problem is actually the line immediately before that one. On test2.wikipedia.org that's where CentralNotice's banner controller loads. On non-updated wikis, it loads at the bottom of the page. The loading hook is BeforePageDisplay in both cases (which it's been using for years). Did someone recently change (fix?) the behavior of that hook? We might just need to switch the hook used in CentralNotice from BeforePageDisplay to SkinAfterBottomScripts, as it really should load at the bottom. (Although I'm not sure why loading at the top would ever cause an error.)
Comment 4 Ryan Kaldari 2012-02-22 05:27:41 UTC
I just tried running CentralNotice inside 1.19wmf1 locally and it works as expected (loads from the bottom). Is it possible test2.wikipedia.org is running some weird version of CentralNotice? (or has some strange hook configuration?)
Comment 5 p858snake 2012-02-22 05:29:25 UTC
It should be running the same centralnotice version as whats in the 1.19wmf1 branch.
Comment 6 Ryan Kaldari 2012-02-22 05:38:47 UTC
I'm running the 1.19wmf1 branch version of CentralNotice and it's behaving differently that the one on test2 (loading at the bottom rather than from the head). Whatever the problem is, it appears to be specific to test2.wikipedia.org.
Revising summary and setting priority as low...
Comment 7 Ryan Kaldari 2012-06-20 19:04:48 UTC
It looks like test2 has wgResourceLoaderExperimentalAsyncLoading turned on. I suspect this is what is causing the problem.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links