Last modified: 2012-02-22 07:27:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36573, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34573 - SemanticMediaWiki: Regression in 1.7.0.2
SemanticMediaWiki: Regression in 1.7.0.2
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
Semantic MediaWiki (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-21 21:23 UTC by Van de Bugger
Modified: 2012-02-22 07:27 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Van de Bugger 2012-02-21 21:23:21 UTC
I am working with Collaboration extension (got it from http://www.smwplus.com). The extension work with SMW 1.6.1, but running it with SMW 1.7.0.2 (or trunk) causes problems:

> Notice: Undefined index: sort in .../SemanticMediaWiki-trunk/includes/SMW_QueryProcessor.php on line 127
> Notice: Undefined index: order in .../SemanticMediaWiki-trunk/includes/SMW_QueryProcessor.php on line 127
> Catchable fatal error: Argument 1 passed to SMWQueryProcessor::getSortKeys() must be an array, null given, called in .../SemanticMediaWiki-trunk/includes/SMW_QueryProcessor.php on line 127 and defined in .../SemanticMediaWiki-trunk/includes/SMW_QueryProcessor.php on line 147

Call stack:

> #0 .../SemanticMediaWiki-trunk/includes/SMW_QueryProcessor.php(363):
> SMWQueryProcessor::createQuery('[[Category:Comm...', Array, 1, 'list', Array)
> #1 .../Collaboration/specials/Comment/CE_CommentParserFunctions.php(362):
> SMWQueryProcessor::getResultFromQueryString('[[Category:Comm...', Array, Array, 2)

Caller code:

> SMWQueryProcessor::processFunctionParams(
>     array("[[Category:Comment]] [[Belongs to article::" . $title->getFullText() . "]]",
>         "[[Has comment rating::+]]", "[[Comment was deleted::!true]]",
>         "?Has comment rating=", "format=list", "mainlabel=-", "searchlabel="
>     ),
>    $querystring, $params, $printouts
> );
> SMWQueryProcessor::getResultFromQueryString(
>     $querystring, $params, $printouts, SMW_OUTPUT_WIKI
> )

At the call time, $params contains 3 elements with indices 'format', 'mainlabe;, 'searchlabel' (as it was specified in original query). No default values are assigned to 'order' and 'sort'.

In SMW 1.6.1, everything described above is the same, but outcome is different: No PHP warnings, no errors.
Comment 1 Jeroen De Dauw 2012-02-21 21:38:11 UTC
This is caused by architecture changes in SMW not matched by the extension you are using. The extension needs to match these changes, nothing that can reasonably be done about this in SMW.
Comment 2 Jeroen De Dauw 2012-02-21 21:38:41 UTC
So you might want to re-file this bug for that extension or contact the developers :)
Comment 3 Markus Krötzsch 2012-02-22 07:27:05 UTC
Changed resolution from WONTFIX to INVALID as it is really not a bug in SMW (as opposed to one that we won't fix).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links