Last modified: 2012-12-24 10:37:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36581, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34581 - [Regression] removeUnusedAccounts.php broken (needs to ignore newuser logging entry)
[Regression] removeUnusedAccounts.php broken (needs to ignore newuser logging...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Maintenance scripts (Other open bugs)
1.20.x
All All
: Normal normal with 2 votes (vote)
: 1.21.0 release
Assigned To: Krinkle
: code-update-regression
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-22 00:31 UTC by Dan Jacobson
Modified: 2012-12-24 10:37 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Quick fix to the issue (831 bytes, patch)
2012-05-31 04:11 UTC, Konstantin Dmitriev
Details
In this version all traces of user also removed from logs (1.27 KB, patch)
2012-06-01 06:33 UTC, Konstantin Dmitriev
Details
removeUnusedAccounts.php to ignore newusers logs and also clean logging/recentchanges (1.40 KB, patch)
2012-12-21 21:58 UTC, Jools Wills
Details

Description Dan Jacobson 2012-02-22 00:31:48 UTC
removeUnusedAccounts.php needs to be revised.
As you know, all new accounts now create a new user log entry.
Therefore removeUnusedAccounts.php will only remove ancient accounts.

This spec,
 * Could the specified user account be deemed inactive?
 * (No edits, no deleted edits, no log entries, no current/old uploads)

Should be revised to
 * (No edits, no deleted edits, no log entries (except for new user log), no current/old uploads)

and the code revised accordingly. Or at least an --option offered.

Also of course the new user log entry should be cleaned up too.

-- All this to make removeUnusedAccounts.php again work as originally intended!
Comment 1 Jamie Thingelstad 2012-05-12 13:22:48 UTC
Just hit this same issue with the new user log keeping this useful script from working. +1 vote to address this.
Comment 2 Konstantin Dmitriev 2012-05-31 04:11:10 UTC
Created attachment 10671 [details]
Quick fix to the issue

Here's my quick fix for issue (patch based on Mediawiki 1.19.0)
Comment 3 Konstantin Dmitriev 2012-06-01 06:33:53 UTC
Created attachment 10674 [details]
In this version all traces of user also removed from logs

We need to remove all traces of user registration from User and Recent Changes logs. Patch against mediawiki 1.19.0.
Comment 4 Sumana Harihareswara 2012-06-01 21:01:45 UTC
Thanks for the patch, Konstantin.

You can use Developer access

https://www.mediawiki.org/wiki/Developer_access

to submit this as a Git branch directly into Gerrit:

https://www.mediawiki.org/wiki/Git/Tutorial

Thanks again!  We appreciate your contribution.  Putting your branch in Git makes it easier for us to review it quickly.
Comment 5 Jools Wills 2012-12-21 21:58:04 UTC
Created attachment 11554 [details]
removeUnusedAccounts.php to ignore newusers logs and also clean logging/recentchanges

Part of the patch didn't apply cleanly on my 1.20 - here is an updated patch.

I was having a lot of automated registrations recently which I wanted to clean up - found this issue after some googling. Seems a relatively important fix as the script is currently non functioning. The patch is also simple, and easy to understand. Any chance someone can sort this ?
Comment 6 Quim Gil 2012-12-21 22:47:20 UTC
Hi Jools, how do you feel about getting developer access and submitting this patch for code review at http://gerrit.wikimedia.org ?

This is how we are currently taking code contributions. The first time you need some extra steps but then you are all set to submit further contributions straight away. Plus, with developer access you get an option to get your own Labs instance to test your patches in a clean environment, without messing with your local installations. 

Have a look: http://www.mediawiki.org/wiki/Developer_access
Comment 7 Rob Kam 2012-12-23 14:51:42 UTC
By the way removeUnusedAccounts.php also removes User:Abuse filter the account for Extension:AbuseFilter.
Comment 8 Krinkle 2012-12-24 04:02:41 UTC
Patch submitted.

Change-Id: I7761a635261881f5a7ff7aaa8f8513d3d3a2149b
Comment 9 Alexandre Emsenhuber [IAlex] 2012-12-24 10:37:30 UTC
Change merged.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links