Last modified: 2012-02-23 00:56:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36599, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 34599 - Special:UploadWizard loading insecure content from commons
Special:UploadWizard loading insecure content from commons
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Unprioritized minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 33045
Blocks:
  Show dependency tree / graph
 
Reported: 2012-02-22 21:00 UTC by Sam Reed (reedy)
Modified: 2012-02-23 00:56 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2012-02-22 21:00:36 UTC 
Seen currently on both test.wiki and test2.wiki:


The page at https://test.wikipedia.org/wiki/Special:UploadWizard displayed insecure content from http://upload.wikimedia.org/wikipedia/commons/4/42/Loading.gif.
Comment 1 Brion Vibber 2012-02-23 00:35:57 UTC 
This appears to actually be in mediawiki.feedback.js in core...

$( '<img src="http://upload.wikimedia.org/wikipedia/commons/4/42/Loading.gif" />' )

As a quick fix I'll just swap it to protocol-relative, but it should be replaced with CSS and a local image.
Comment 2 Brion Vibber 2012-02-23 00:37:35 UTC 
r112169 does the protocol-relative switch
Comment 3 Brion Vibber 2012-02-23 00:56:55 UTC 
r112172 does a proper fix, turning it into a locally-hosted .gif loaded via
styles in the module.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links