Last modified: 2013-10-23 18:17:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36600, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 34600 - Incorrect head scripts when useHeadElement=false


Summary:	Incorrect head scripts when useHeadElement=false

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	General/Unknown (Other open bugs)
Version:	1.18.x
Hardware:	All All

Importance:	Unprioritized major (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-02-22 21:02 UTC by Vitaliy Filippov
Modified:	2013-10-23 18:17 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
The patch (500 bytes, patch) 2012-02-22 21:02 UTC, Vitaliy Filippov	Details
Add an attachment (proposed patch, testcase, etc.)

Description Vitaliy Filippov 2012-02-22 21:02:24 UTC

Created attachment 10073 [details]
The patch

There is a serious backwards compatibilty (with older skins) problem in MediaWiki 1.18.1: 'headscripts' template data is set incorrectly when useHeadElement=false. This a) causes mediawiki.page.startup to not load and b) duplicates scripts which added with $wgOut->addScript(...).
The fix is very simple - 1-line patch in the attachment.

Comment 1 Vitaliy Filippov 2012-02-22 21:03:00 UTC

(scripts are duplicated in <head> and bottom of the page)

Comment 2 Roan Kattouw 2012-02-22 21:45:24 UTC

Thanks for noticing, and thanks for the patch! Applied with a slight modification (removed the $this parameter to match the 1.19 function signature) in r112152.

Comment 3 Vitaliy Filippov 2012-02-23 17:15:22 UTC

Thanks for approving the patch. Do you plan to back-port it to 1.18.2?

Comment 4 Vitaliy Filippov 2012-02-24 12:11:41 UTC

I think you should back-port it, as well as bug 34687. These are serious bugs :).

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links