Last modified: 2012-03-30 22:15:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36610, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 34610 - Usability: label element in replace of span around checkboxes and radio buttons


Summary:	Usability: label element in replace of span around checkboxes and radio buttons

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	SemanticForms (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Yaron Koren

URL:
Whiteboard:
Keywords:	patch, patch-need-review

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-02-23 10:20 UTC by Andru
Modified:	2012-03-30 22:15 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
DIFF patch to change span elements to label elements for checkboxes and radiobuttons (1.11 KB, patch) 2012-02-23 10:20 UTC, Andru	Details
Add an attachment (proposed patch, testcase, etc.)

Description Andru 2012-02-23 10:20:21 UTC

Created attachment 10078 [details]
DIFF patch to change span elements to label elements for checkboxes and radiobuttons

Hi,
I'm submitting a diff for a small change to radiobuttons and checkboxes - currently they are enclosed in span elements, which makes their click area just the tiny checkbox or radiobutton itsself. The attached diff changes the span to a label element to improve usability by increasing the click target to the whole label.

Please note this diff only changes the actual element itself. Variable names and someclass names and css selectors still contain the string 'span'. If this change is accepted, I would be happy to update the relevant variables and css selectors.

Thanks
Andru

Comment 1 Sumana Harihareswara 2012-02-23 22:37:31 UTC

Thanks for the patch, Andru!  I've attached keywords to this bug to ask code reviewers to look at it soon.

best,
Sumana

Comment 2 Yaron Koren 2012-02-23 22:43:07 UTC

Sumana - I think you've mistaken an extension-related patch for a MediaWiki one again.

Comment 3 Yaron Koren 2012-03-30 22:15:24 UTC

Andru - sorry for the long delay, and thanks for this patch. I just checked it in to SVN, in modified form.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links