Last modified: 2014-10-14 02:22:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36646, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34646 - Filter by patrolled-status
Filter by patrolled-status
Status: NEW
Product: Huggle
Classification: Unclassified
Application (Other open bugs)
unspecified
All All
: Lowest enhancement
: ---
Assigned To: Peter Bena
:
Depends on:
Blocks: 51545
  Show dependency treegraph
 
Reported: 2012-02-23 19:11 UTC by Michael Movchin
Modified: 2014-10-14 02:22 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Michael Movchin 2012-02-23 19:11:22 UTC
Originally reported by laaknor, Jan 1, 2009
___________________________________________________________

It should be possible to filter changes by patrol-status. Wikis using
patrolling for NewPages (all Wikimedia-wikis AFAIK) and/or RecentChanges
(several Wikimedia-wikis).
___________________________________________________________

Moved from the Google Code Issues Tracker (http://code.google.com/p/huggle/issues/list)
___________________________________________________________
Comment 1 by ubley2286, Jan 11, 2009
feasible for queues fed from recentchanges but not arbitrary queues, as 'patrolled'
is an attribute of a recentchanges table entry, not an edit or page
Comment 1 Lars Ã…ge Kamfjord 2013-01-20 19:04:14 UTC
Any plans to implement this?
Comment 2 Peter Bena 2013-12-10 14:30:12 UTC
Patrolling is disabled on most of WMF wikis, so this feature has really very low priority
Comment 3 Helder 2014-06-07 19:25:23 UTC
Actually, this feature is enabled in many wikis:
https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/InitialiseSettings.php#L6109-L6178
and it makes e.g. RTRC[1] a lot more convenient than Huggle.

[1] https://meta.wikimedia.org/wiki/User:Krinkle/Tools/Real-Time_Recent_Changes
Comment 4 Peter Bena 2014-07-29 15:53:07 UTC
how is it easily possible to check if edit is patrolled or not, can you provide me some api's for that?
Comment 5 Helder 2014-07-29 16:35:41 UTC
https://pt.wikipedia.org/w/api.php?action=query&list=recentchanges&format=xmlfm&rcprop=patrolled&rclimit=5
returns this:
<api>
  <query-continue>
    <recentchanges rccontinue="20140729163241|50125373" />
  </query-continue>
  <query>
    <recentchanges>
      <rc type="edit" patrolled="" />
      <rc type="edit" unpatrolled="" />
      <rc type="edit" patrolled="" />
      <rc type="edit" patrolled="" />
      <rc type="external" patrolled="" />
    </recentchanges>
  </query>
</api>
and RTRC uses this:
https://github.com/Krinkle/mw-gadget-rtrc/blob/master/src/rtrc.js#L196-L197
// Convert undefined/empty-string values from API into booleans
isUnpatrolled = rc.unpatrolled !== undefined;
Comment 6 Peter Bena 2014-07-29 17:57:15 UTC
well, that is something I could implement for api based RC provider, not IRC feed. Is there a way to query this for a specific revision id?
Comment 7 Helder 2014-07-29 18:17:50 UTC
(In reply to Peter Bena from comment #6)
> well, that is something I could implement for api based RC provider, not IRC
> feed. Is there a way to query this for a specific revision id?

I don't know. Maybe Krinkle knows?
Comment 8 Peter Bena 2014-08-07 14:08:17 UTC
There should be a reliable way to verify this, if there is no such, having this option in huggle would make no sense
Comment 9 Danilo 2014-08-07 19:05:08 UTC
I think there is not a direct way to verify the patroll status. The recentchanges table is not indexed by rc_this_oldid column, so the query "SELECT * FROM recentchanges WHERE rc_this_oldid = <some id>" is lazy, and this is probably the reason why API code don't have this option. But it can be verified based in the revision timestamp.

For example we want the patroll status for the revision 39732296, the timestamp is 20140804073720, so we make the query https://pt.wikipedia.org/w/api.php?action=query&list=recentchanges&format=xml&rcstart=20140804073720&rcprop=timestamp|ids|patrolled&rctype=new|edit&rclimit=3 and get the patrolled/unpatrolled making the code look only the row where 'revid == 39732296'.
Comment 10 Peter Bena 2014-08-08 06:55:54 UTC
that is a pretty hacky way... inserted some API people to have a look on this
Comment 11 Brad Jorsch 2014-08-08 07:31:31 UTC
Comment 9 appears to be correct, there currently doesn't seem to be a good way to find a particular RC entry except by timestamp.

Adding an 'rcids' parameter to list=recentchanges looks like it would be easy enough, which would let you query by rc_id if you have that.

To query by rev_id, there would first need to be an index added on rc_this_oldid.
Comment 12 Peter Bena 2014-08-27 13:54:35 UTC
until mentioned issues are resolved (make it possible to query this information using api directly) there is no point in implementing this feature to huggle as it would be extremely complicated given lack of mediawiki functionality in this area
Comment 13 Nemo 2014-08-27 13:57:30 UTC
(In reply to Peter Bena from comment #12)
> lack of
> mediawiki functionality in this area

There should be a blocking bug filed against MediaWiki then...

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links